yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-12-27 18:07:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(dataset stats): Fix checks for existence of row and column counts (#3003)

Browse Source
This commit is contained in:
John Joyce 2021-08-02 07:53:37 -07:00 committed by GitHub
parent 411bbeab56
commit beb9b623fb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
datahub-web-react/src/app/entity/dataset/profile/__tests__/Stats.tsx → datahub-web-react/src/app/entity/dataset/profile/__tests__/Stats.test.tsx
View File

@ -107,10 +107,12 @@ describe('SnapshotStatsView', () => {
// Row Count
expect(queryByText('1000')).toBeNull();
expect(queryByText('Rows')).toBeNull();
expect(queryByText('Row Count Unknown')).toBeInTheDocument();
// Column Count
expect(queryByText('2000')).toBeNull();
expect(queryByText('Columns')).toBeNull();
expect(queryByText('Column Count Unknown')).toBeInTheDocument();
// Field Profiles
// First column

8
datahub-web-react/src/app/entity/dataset/profile/stats/snapshot/SnapshotStatsView.tsx
View File

@ -151,11 +151,11 @@ export default function DataProfileView({ profile }: Props) {
const columnStatsColumns = buildColumnStatsColumns(columnStatsTableData);
const rowCount = profile?.rowCount || -1;
const rowCountTitle = (rowCount > 0 && 'Rows') || '?';
const rowCount = (isPresent(profile?.rowCount) ? profile?.rowCount : -1) as number;
const rowCountTitle = (rowCount >= 0 && 'Rows') || 'Row Count Unknown';
const columnCount = profile?.columnCount || -1;
const columnCountTitle = (columnCount > 0 && 'Columns') || '?';
const columnCount = (isPresent(profile?.columnCount) ? profile?.columnCount : -1) as number;
const columnCountTitle = (columnCount >= 0 && 'Columns') || 'Column Count Unknown';
return (
<>