yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-08-15 04:37:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(web) fallback to search to get count (#13556)

Browse Source
This commit is contained in:
Jay 2025-05-30 15:17:31 -04:00 committed by GitHub
parent 4f41832ca8
commit bf174e47e7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
datahub-web-react/src/app/ingest/source/IngestedAssets.tsx
View File

@ -78,7 +78,7 @@ export default function IngestedAssets({ id, executionResult }: Props) {
// First thing to do is to search for all assets with the id as the run id!
// Execute search
const { data, loading, error } = useGetSearchResultsForMultipleQuery({
skip: totalEntitiesIngested === null || entitiesIngestedByTypeFromReport === null,
skip: typeof totalEntitiesIngested === 'number' && !!entitiesIngestedByTypeFromReport?.length,
variables: {
input: {
query: '*',

2
datahub-web-react/src/app/ingest/source/__tests__/tests_utils.test.tsx
View File

@ -91,7 +91,7 @@ describe('getEntitiesIngestedByType', () => {
};
const result = getEntitiesIngestedByType(mockExecutionRequestResult(structuredReport));
expect(result).toEqual([]);
expect(result).toBeNull();
});
test('handles aspects with non-numeric values', () => {

4
datahub-web-react/src/app/ingest/source/utils.ts
View File

@ -352,6 +352,10 @@ export const getEntitiesIngestedByType = (result: Partial<ExecutionRequestResult
entitiesIngestedByType[entityName] = Math.max(...(Object.values(aspects as object) as number[]));
});
if (Object.keys(entitiesIngestedByType).length === 0) {
return null;
}
return Object.entries(entitiesIngestedByType).map(([entityName, count]) => ({
count,
displayName: entityName,

2
datahub-web-react/src/app/ingestV2/source/IngestedAssets.tsx
View File

@ -78,7 +78,7 @@ export default function IngestedAssets({ id, executionResult }: Props) {
// First thing to do is to search for all assets with the id as the run id!
// Execute search
const { data, loading, error } = useGetSearchResultsForMultipleQuery({
skip: totalEntitiesIngested === null || entitiesIngestedByTypeFromReport === null,
skip: typeof totalEntitiesIngested === 'number' && !!entitiesIngestedByTypeFromReport?.length,
variables: {
input: {
query: '*',

2
datahub-web-react/src/app/ingestV2/source/__tests__/tests_utils.test.tsx
View File

@ -91,7 +91,7 @@ describe('getEntitiesIngestedByType', () => {
};
const result = getEntitiesIngestedByType(mockExecutionRequestResult(structuredReport));
expect(result).toEqual([]);
expect(result).toBeNull();
});
test('handles aspects with non-numeric values', () => {

4
datahub-web-react/src/app/ingestV2/source/utils.ts
View File

@ -343,6 +343,10 @@ export const getEntitiesIngestedByType = (result: Partial<ExecutionRequestResult
entitiesIngestedByType[entityName] = Math.max(...(Object.values(aspects as object) as number[]));
});
if (Object.keys(entitiesIngestedByType).length === 0) {
return null;
}
return Object.entries(entitiesIngestedByType).map(([entityName, count]) => ({
count,
displayName: entityName,