fix(ingest): fix schema field urns with empty field path (#6338)

This commit is contained in:
Mayuri Nehate 2022-11-02 19:32:13 +05:30 committed by GitHub
parent b4687ffceb
commit c01aa53aa7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 11 deletions

View File

@ -53,7 +53,6 @@ from datahub.ingestion.source.tableau_common import (
clean_query,
custom_sql_graphql_query,
embedded_datasource_graphql_query,
get_field_value_in_sheet,
get_unique_custom_sql,
make_table_urn,
published_datasource_graphql_query,
@ -1325,8 +1324,6 @@ class TableauSource(StatefulIngestionSourceBase):
field.get("datasource")["id"] if field.get("datasource") else None
)
if name and upstream_ds_id:
name = get_field_value_in_sheet(field, "name")
input_fields.append(
InputField(
schemaFieldUrn=builder.make_schema_field_urn(

View File

@ -574,13 +574,6 @@ def make_description_from_params(description, formula):
return final_description
def get_field_value_in_sheet(field, field_name):
if field.get("__typename", "") == "DatasourceField":
field = field.get("remoteField") or {}
return field.get(field_name, "")
def get_unique_custom_sql(custom_sql_list: List[dict]) -> List[dict]:
unique_custom_sql = []
for custom_sql in custom_sql_list:

View File

@ -4178,7 +4178,7 @@
"remoteField": {
"__typename": "ColumnField",
"id": "ca23efe0-5a93-344a-3f69-ec777ee1b318",
"name": "customer_first_name",
"name": "",
"description": null,
"folderName": null,
"dataCategory": "NOMINAL",