yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-11-16 03:13:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): Removing unused props and trimming down the graphql objects (#15043)

Browse Source
This commit is contained in:
Saketh Varma 2025-10-21 13:40:05 +05:30 committed by GitHub
parent 27fca1c0bf
commit c436e97e84
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 2 additions and 45 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
datahub-web-react/src/app/entityV2/chart/ChartEntity.tsx
View File

@ -45,7 +45,6 @@ import { PropertiesTab } from '@app/entityV2/shared/tabs/Properties/PropertiesTa
import { import {
SidebarTitleActionType, SidebarTitleActionType,
getDashboardLastUpdatedMs, getDashboardLastUpdatedMs,
getDataProduct,
getFirstSubType, getFirstSubType,
isOutputPort, isOutputPort,
} from '@app/entityV2/shared/utils'; } from '@app/entityV2/shared/utils';
@ -292,8 +291,6 @@ export class ChartEntity implements Entity<Chart> {
tags={data?.globalTags || undefined} tags={data?.globalTags || undefined}
glossaryTerms={data?.glossaryTerms} glossaryTerms={data?.glossaryTerms}
logoUrl={data?.platform?.properties?.logoUrl} logoUrl={data?.platform?.properties?.logoUrl}
domain={data.domain?.domain}
dataProduct={getDataProduct(genericProperties?.dataProduct)}
parentContainers={data.parentContainers} parentContainers={data.parentContainers}
subType={getFirstSubType(data)} subType={getFirstSubType(data)}
headerDropdownItems={headerDropdownItems} headerDropdownItems={headerDropdownItems}
@ -322,8 +319,6 @@ export class ChartEntity implements Entity<Chart> {
glossaryTerms={data?.glossaryTerms} glossaryTerms={data?.glossaryTerms}
insights={result.insights} insights={result.insights}
logoUrl={data?.platform?.properties?.logoUrl || ''} logoUrl={data?.platform?.properties?.logoUrl || ''}
domain={data.domain?.domain}
dataProduct={getDataProduct(genericProperties?.dataProduct)}
deprecation={data.deprecation} deprecation={data.deprecation}
statsSummary={data.statsSummary} statsSummary={data.statsSummary}
lastUpdatedMs={getDashboardLastUpdatedMs(data?.properties)} lastUpdatedMs={getDashboardLastUpdatedMs(data?.properties)}

5
datahub-web-react/src/app/entityV2/dashboard/DashboardEntity.tsx
View File

@ -46,7 +46,6 @@ import { PropertiesTab } from '@app/entityV2/shared/tabs/Properties/PropertiesTa
import { import {
SidebarTitleActionType, SidebarTitleActionType,
getDashboardLastUpdatedMs, getDashboardLastUpdatedMs,
getDataProduct,
getFirstSubType, getFirstSubType,
isOutputPort, isOutputPort,
} from '@app/entityV2/shared/utils'; } from '@app/entityV2/shared/utils';
@ -282,8 +281,6 @@ export class DashboardEntity implements Entity<Dashboard> {
owners={data.ownership?.owners} owners={data.ownership?.owners}
glossaryTerms={data?.glossaryTerms} glossaryTerms={data?.glossaryTerms}
logoUrl={data?.platform?.properties?.logoUrl} logoUrl={data?.platform?.properties?.logoUrl}
domain={data.domain?.domain}
dataProduct={getDataProduct(genericProperties?.dataProduct)}
container={data.container} container={data.container}
parentContainers={data.parentContainers} parentContainers={data.parentContainers}
deprecation={data.deprecation} deprecation={data.deprecation}
@ -317,8 +314,6 @@ export class DashboardEntity implements Entity<Dashboard> {
glossaryTerms={data?.glossaryTerms} glossaryTerms={data?.glossaryTerms}
insights={result.insights} insights={result.insights}
logoUrl={data?.platform?.properties?.logoUrl || ''} logoUrl={data?.platform?.properties?.logoUrl || ''}
domain={data.domain?.domain}
dataProduct={getDataProduct(genericProperties?.dataProduct)}
container={data.container} container={data.container}
parentContainers={data.parentContainers} parentContainers={data.parentContainers}
deprecation={data.deprecation} deprecation={data.deprecation}

6
datahub-web-react/src/app/entityV2/dataFlow/DataFlowEntity.tsx
View File

@ -25,7 +25,7 @@ import { DataFlowJobsTab } from '@app/entityV2/shared/tabs/Entity/DataFlowJobsTa
import { IncidentTab } from '@app/entityV2/shared/tabs/Incident/IncidentTab'; import { IncidentTab } from '@app/entityV2/shared/tabs/Incident/IncidentTab';
import { DAGTab } from '@app/entityV2/shared/tabs/Lineage/DAGTab'; import { DAGTab } from '@app/entityV2/shared/tabs/Lineage/DAGTab';
import { PropertiesTab } from '@app/entityV2/shared/tabs/Properties/PropertiesTab'; import { PropertiesTab } from '@app/entityV2/shared/tabs/Properties/PropertiesTab';
import { getDataProduct, isOutputPort } from '@app/entityV2/shared/utils'; import { isOutputPort } from '@app/entityV2/shared/utils';
import { capitalizeFirstLetterOnly } from '@app/shared/textUtil'; import { capitalizeFirstLetterOnly } from '@app/shared/textUtil';
import { useGetDataFlowQuery, useUpdateDataFlowMutation } from '@graphql/dataFlow.generated'; import { useGetDataFlowQuery, useUpdateDataFlowMutation } from '@graphql/dataFlow.generated';
@ -196,8 +196,6 @@ export class DataFlowEntity implements Entity<DataFlow> {
platformLogo={data?.platform?.properties?.logoUrl || ''} platformLogo={data?.platform?.properties?.logoUrl || ''}
owners={data.ownership?.owners} owners={data.ownership?.owners}
globalTags={data.globalTags} globalTags={data.globalTags}
domain={data.domain?.domain}
dataProduct={getDataProduct(genericProperties?.dataProduct)}
externalUrl={data.properties?.externalUrl} externalUrl={data.properties?.externalUrl}
headerDropdownItems={headerDropdownItems} headerDropdownItems={headerDropdownItems}
previewType={previewType} previewType={previewType}
@ -223,8 +221,6 @@ export class DataFlowEntity implements Entity<DataFlow> {
owners={data.ownership?.owners} owners={data.ownership?.owners}
globalTags={data.globalTags} globalTags={data.globalTags}
insights={result.insights} insights={result.insights}
domain={data.domain?.domain}
dataProduct={getDataProduct(genericProperties?.dataProduct)}
externalUrl={data.properties?.externalUrl} externalUrl={data.properties?.externalUrl}
jobCount={(data as any).childJobs?.total} jobCount={(data as any).childJobs?.total}
deprecation={data.deprecation} deprecation={data.deprecation}

6
datahub-web-react/src/app/entityV2/dataJob/DataJobEntity.tsx
View File

@ -30,7 +30,7 @@ import { DataJobFlowTab } from '@app/entityV2/shared/tabs/Entity/DataJobFlowTab'
import { IncidentTab } from '@app/entityV2/shared/tabs/Incident/IncidentTab'; import { IncidentTab } from '@app/entityV2/shared/tabs/Incident/IncidentTab';
import { LineageTab } from '@app/entityV2/shared/tabs/Lineage/LineageTab'; import { LineageTab } from '@app/entityV2/shared/tabs/Lineage/LineageTab';
import { PropertiesTab } from '@app/entityV2/shared/tabs/Properties/PropertiesTab'; import { PropertiesTab } from '@app/entityV2/shared/tabs/Properties/PropertiesTab';
import { SidebarTitleActionType, getDataProduct, getFirstSubType, isOutputPort } from '@app/entityV2/shared/utils'; import { SidebarTitleActionType, getFirstSubType, isOutputPort } from '@app/entityV2/shared/utils';
import { EntityAndType } from '@app/lineage/types'; import { EntityAndType } from '@app/lineage/types';
import { capitalizeFirstLetterOnly } from '@app/shared/textUtil'; import { capitalizeFirstLetterOnly } from '@app/shared/textUtil';
@ -211,8 +211,6 @@ export class DataJobEntity implements Entity<DataJob> {
platformLogo={getPlatformForDataJob(data)?.properties?.logoUrl || ''} platformLogo={getPlatformForDataJob(data)?.properties?.logoUrl || ''}
owners={data.ownership?.owners} owners={data.ownership?.owners}
globalTags={data.globalTags || null} globalTags={data.globalTags || null}
domain={data.domain?.domain}
dataProduct={getDataProduct(genericProperties?.dataProduct)}
externalUrl={data.properties?.externalUrl} externalUrl={data.properties?.externalUrl}
headerDropdownItems={headerDropdownItems} headerDropdownItems={headerDropdownItems}
previewType={previewType} previewType={previewType}
@ -236,8 +234,6 @@ export class DataJobEntity implements Entity<DataJob> {
platformInstanceId={data.dataPlatformInstance?.instanceId} platformInstanceId={data.dataPlatformInstance?.instanceId}
owners={data.ownership?.owners} owners={data.ownership?.owners}
globalTags={data.globalTags} globalTags={data.globalTags}
domain={data.domain?.domain}
dataProduct={getDataProduct(genericProperties?.dataProduct)}
deprecation={data.deprecation} deprecation={data.deprecation}
insights={result.insights} insights={result.insights}
externalUrl={data.properties?.externalUrl} externalUrl={data.properties?.externalUrl}

5
datahub-web-react/src/app/entityV2/dataset/DatasetEntity.tsx
View File

@ -56,7 +56,6 @@ import { LineageTab } from '@app/entityV2/shared/tabs/Lineage/LineageTab';
import { PropertiesTab } from '@app/entityV2/shared/tabs/Properties/PropertiesTab'; import { PropertiesTab } from '@app/entityV2/shared/tabs/Properties/PropertiesTab';
import { import {
SidebarTitleActionType, SidebarTitleActionType,
getDataProduct,
getDatasetLastUpdatedMs, getDatasetLastUpdatedMs,
getFirstSubType, getFirstSubType,
isOutputPort, isOutputPort,
@ -401,8 +400,6 @@ export class DatasetEntity implements Entity<Dataset> {
owners={data.ownership?.owners} owners={data.ownership?.owners}
globalTags={data.globalTags} globalTags={data.globalTags}
glossaryTerms={data.glossaryTerms} glossaryTerms={data.glossaryTerms}
domain={data.domain?.domain}
dataProduct={getDataProduct(genericProperties?.dataProduct)}
container={data.container} container={data.container}
externalUrl={data.properties?.externalUrl} externalUrl={data.properties?.externalUrl}
health={data.health} health={data.health}
@ -438,8 +435,6 @@ export class DatasetEntity implements Entity<Dataset> {
platformLogos={genericProperties?.siblingPlatforms?.map((platform) => platform.properties?.logoUrl)} platformLogos={genericProperties?.siblingPlatforms?.map((platform) => platform.properties?.logoUrl)}
owners={data.ownership?.owners} owners={data.ownership?.owners}
globalTags={data.globalTags} globalTags={data.globalTags}
domain={data.domain?.domain}
dataProduct={getDataProduct(genericProperties?.dataProduct)}
deprecation={data.deprecation} deprecation={data.deprecation}
glossaryTerms={data.glossaryTerms} glossaryTerms={data.glossaryTerms}
subtype={getFirstSubType(data)} subtype={getFirstSubType(data)}

20
datahub-web-react/src/graphql/search.graphql
View File

@ -480,10 +480,6 @@ fragment nonSiblingsDatasetSearchFields on Dataset {
subTypes { subTypes {
typeNames typeNames
} }
domain {
...entityDomain
}
...entityDataProduct
parentContainers { parentContainers {
...parentContainersFields ...parentContainersFields
} }
@ -634,10 +630,6 @@ fragment searchResultsWithoutSchemaField on Entity {
dataPlatformInstance { dataPlatformInstance {
...dataPlatformInstanceFields ...dataPlatformInstanceFields
} }
domain {
...entityDomain
}
...entityDataProduct
deprecation { deprecation {
...deprecationFields ...deprecationFields
} }
@ -714,10 +706,6 @@ fragment searchResultsWithoutSchemaField on Entity {
dataPlatformInstance { dataPlatformInstance {
...dataPlatformInstanceFields ...dataPlatformInstanceFields
} }
domain {
...entityDomain
}
...entityDataProduct
deprecation { deprecation {
...deprecationFields ...deprecationFields
} }
@ -792,10 +780,6 @@ fragment searchResultsWithoutSchemaField on Entity {
parentContainers { parentContainers {
...parentContainersFields ...parentContainersFields
} }
domain {
...entityDomain
}
...entityDataProduct
deprecation { deprecation {
...deprecationFields ...deprecationFields
} }
@ -839,10 +823,6 @@ fragment searchResultsWithoutSchemaField on Entity {
editableProperties { editableProperties {
description description
} }
domain {
...entityDomain
}
...entityDataProduct
deprecation { deprecation {
...deprecationFields ...deprecationFields
} }