From c43e119b3e0e247b4ba4cd322e7381160cc3a24e Mon Sep 17 00:00:00 2001
From: Mars Lan <mars.th.lan@gmail.com>
Date: Fri, 8 May 2020 14:39:20 -0700
Subject: [PATCH] refactor: change the default log location (#1667)

The original location (/local/log) is not a commonly writable location on Mac & Linux.
The new default location also matches the default data location for docker containers.
---
 datahub-frontend/conf/logback.xml                           | 6 +++---
 gms/war/src/main/resources/logback.xml                      | 2 +-
 .../mae-consumer-job/src/main/resources/logback.xml         | 2 +-
 .../mce-consumer-job/src/main/resources/logback.xml         | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/datahub-frontend/conf/logback.xml b/datahub-frontend/conf/logback.xml
index 8bfcb12105..41de6ebab3 100644
--- a/datahub-frontend/conf/logback.xml
+++ b/datahub-frontend/conf/logback.xml
@@ -1,5 +1,5 @@
 <configuration>
-  <property name="WHZ_LOG_DIR" value="${WHZ_LOG_DIR:- /var/tmp/datahub}"/>
+  <property name="LOG_DIR" value="${LOG_DIR:- /tmp/datahub/logs}"/>
   <timestamp key="bySecond" datePattern="yyyy-MM-dd'_'HH-mm-ss"/>
   <timestamp key="byDate" datePattern="yyyy-MM-dd"/>
 
@@ -10,14 +10,14 @@
   </appender>
 
   <appender name="FILE" class="ch.qos.logback.core.rolling.RollingFileAppender">
-    <file>${WHZ_LOG_DIR}/datahub-frontend-${bySecond}.log</file>
+    <file>${LOG_DIR}/datahub-frontend-${bySecond}.log</file>
     <append>true</append>
     <encoder>
       <pattern>%d{HH:mm:ss} [%thread] %-5level %logger{36} - %msg%n</pattern>
     </encoder>
     <rollingPolicy class="ch.qos.logback.core.rolling.FixedWindowRollingPolicy">
       <maxIndex>10</maxIndex>
-      <FileNamePattern>${WHZ_LOG_DIR}/${byDate}.log.%i</FileNamePattern>
+      <FileNamePattern>${LOG_DIR}/${byDate}.log.%i</FileNamePattern>
     </rollingPolicy>
     <triggeringPolicy class="ch.qos.logback.core.rolling.SizeBasedTriggeringPolicy">
       <MaxFileSize>20MB</MaxFileSize>
diff --git a/gms/war/src/main/resources/logback.xml b/gms/war/src/main/resources/logback.xml
index cf2b2568ab..6628ae4067 100644
--- a/gms/war/src/main/resources/logback.xml
+++ b/gms/war/src/main/resources/logback.xml
@@ -1,5 +1,5 @@
 <configuration>
-    <property name="LOG_DIR" value="${LOG_DIR:- /local/logs}"/>
+    <property name="LOG_DIR" value="${LOG_DIR:- /tmp/datahub/logs}"/>
 
     <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
         <encoder>
diff --git a/metadata-jobs/mae-consumer-job/src/main/resources/logback.xml b/metadata-jobs/mae-consumer-job/src/main/resources/logback.xml
index 2045dbf92b..242c9ce28c 100644
--- a/metadata-jobs/mae-consumer-job/src/main/resources/logback.xml
+++ b/metadata-jobs/mae-consumer-job/src/main/resources/logback.xml
@@ -1,5 +1,5 @@
 <configuration>
-    <property name="LOG_DIR" value="${LOG_DIR:- /local/logs}"/>
+    <property name="LOG_DIR" value="${LOG_DIR:- /tmp/datahub/logs}"/>
 
     <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
         <encoder>
diff --git a/metadata-jobs/mce-consumer-job/src/main/resources/logback.xml b/metadata-jobs/mce-consumer-job/src/main/resources/logback.xml
index 17b9176ed7..4a9eb82899 100644
--- a/metadata-jobs/mce-consumer-job/src/main/resources/logback.xml
+++ b/metadata-jobs/mce-consumer-job/src/main/resources/logback.xml
@@ -1,5 +1,5 @@
 <configuration>
-    <property name="LOG_DIR" value="${LOG_DIR:- /local/logs}"/>
+    <property name="LOG_DIR" value="${LOG_DIR:- /tmp/datahub/logs}"/>
 
     <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
         <encoder>