yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-08-11 10:46:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ingest): hint at --update-golden-files option when tests fail (#8507)

Browse Source
This commit is contained in:
Harshal Sheth 2023-07-25 21:20:27 -07:00 committed by GitHub
parent 8a23c37e7c
commit c585a1bcc7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
metadata-ingestion/src/datahub/testing/compare_metadata_json.py
View File

@ -45,7 +45,7 @@ def assert_metadata_files_equal(
if copy_output: if copy_output:
shutil.copyfile(str(output_path), str(golden_path) + ".output") shutil.copyfile(str(output_path), str(golden_path) + ".output")
print(f"Copied output file to {golden_path}.output") logger.info(f"Copied output file to {golden_path}.output")
if not update_golden and not golden_exists: if not update_golden and not golden_exists:
raise FileNotFoundError( raise FileNotFoundError(
@ -77,11 +77,15 @@ def assert_metadata_files_equal(
if diff: if diff:
# Call pytest.fail rather than raise an exception to omit stack trace # Call pytest.fail rather than raise an exception to omit stack trace
message = (
"Metadata files differ (use `pytest --update-golden-files` to update):\n"
)
if isinstance(diff, MCPDiff): if isinstance(diff, MCPDiff):
print(diff.pretty(verbose=True)) logger.error(message + diff.pretty(verbose=True))
pytest.fail(diff.pretty(), pytrace=False) pytest.fail(message + diff.pretty(), pytrace=False)
else: else:
pytest.fail(pprint.pformat(diff), pytrace=False) logger.error(message + pprint.pformat(diff))
pytest.fail(message + pprint.pformat(diff), pytrace=False)
def diff_metadata_json( def diff_metadata_json(