From c73b6660eb030d0733b0093360fb2bcb65120adf Mon Sep 17 00:00:00 2001 From: Chris Collins Date: Tue, 11 Mar 2025 14:00:51 -0600 Subject: [PATCH] fix(ui) Hide default filters we want to hide from impact analysis (#12843) --- datahub-web-react/src/app/search/SimpleSearchFilters.tsx | 9 ++++++++- datahub-web-react/src/app/search/utils/constants.ts | 1 + .../src/app/searchV2/SimpleSearchFilters.tsx | 8 +++++++- 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/datahub-web-react/src/app/search/SimpleSearchFilters.tsx b/datahub-web-react/src/app/search/SimpleSearchFilters.tsx index 877efb55fc..79d4718a8e 100644 --- a/datahub-web-react/src/app/search/SimpleSearchFilters.tsx +++ b/datahub-web-react/src/app/search/SimpleSearchFilters.tsx @@ -8,12 +8,19 @@ import { DEGREE_FILTER_NAME, ENTITY_FILTER_NAME, ENTITY_INDEX_FILTER_NAME, + ENTITY_SUB_TYPE_FILTER_NAME, LEGACY_ENTITY_FILTER_NAME, + SCHEMA_FIELD_ALIASES_FILTER_NAME, } from './utils/constants'; const TOP_FILTERS = ['degree', ENTITY_FILTER_NAME, 'platform', 'tags', 'glossaryTerms', 'domains', 'owners']; -const FILTERS_TO_EXCLUDE = [LEGACY_ENTITY_FILTER_NAME, ENTITY_INDEX_FILTER_NAME]; +const FILTERS_TO_EXCLUDE = [ + LEGACY_ENTITY_FILTER_NAME, + ENTITY_INDEX_FILTER_NAME, + ENTITY_SUB_TYPE_FILTER_NAME, + SCHEMA_FIELD_ALIASES_FILTER_NAME, +]; interface Props { facets: Array; diff --git a/datahub-web-react/src/app/search/utils/constants.ts b/datahub-web-react/src/app/search/utils/constants.ts index ea3d80891b..bb74c72316 100644 --- a/datahub-web-react/src/app/search/utils/constants.ts +++ b/datahub-web-react/src/app/search/utils/constants.ts @@ -40,6 +40,7 @@ export const INCOMPLETE_FORMS_FILTER_NAME = 'incompleteForms'; export const VERIFIED_FORMS_FILTER_NAME = 'verifiedForms'; export const COMPLETED_FORMS_COMPLETED_PROMPT_IDS_FILTER_NAME = 'completedFormsCompletedPromptIds'; export const INCOMPLETE_FORMS_COMPLETED_PROMPT_IDS_FILTER_NAME = 'incompleteFormsCompletedPromptIds'; +export const SCHEMA_FIELD_ALIASES_FILTER_NAME = 'schemaFieldAliases'; export const LEGACY_ENTITY_FILTER_FIELDS = [ENTITY_FILTER_NAME, LEGACY_ENTITY_FILTER_NAME]; diff --git a/datahub-web-react/src/app/searchV2/SimpleSearchFilters.tsx b/datahub-web-react/src/app/searchV2/SimpleSearchFilters.tsx index bfb4c66186..68bdc1c9bf 100644 --- a/datahub-web-react/src/app/searchV2/SimpleSearchFilters.tsx +++ b/datahub-web-react/src/app/searchV2/SimpleSearchFilters.tsx @@ -11,10 +11,16 @@ import { ENTITY_SUB_TYPE_FILTER_NAME, DEGREE_FILTER_NAME, } from './utils/constants'; +import { SCHEMA_FIELD_ALIASES_FILTER_NAME } from '../search/utils/constants'; const TOP_FILTERS = ['degree', ENTITY_FILTER_NAME, 'platform', 'tags', 'glossaryTerms', 'domains', 'owners']; -const FILTERS_TO_EXCLUDE = [LEGACY_ENTITY_FILTER_NAME, ENTITY_INDEX_FILTER_NAME, ENTITY_SUB_TYPE_FILTER_NAME]; +const FILTERS_TO_EXCLUDE = [ + LEGACY_ENTITY_FILTER_NAME, + ENTITY_INDEX_FILTER_NAME, + ENTITY_SUB_TYPE_FILTER_NAME, + SCHEMA_FIELD_ALIASES_FILTER_NAME, +]; interface Props { facets: Array;