yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-08-19 14:44:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(datahub-upgrade): removing the CleanupStep from datahub upgrade (#2728)

Browse Source
This commit is contained in:
John Joyce 2021-06-24 23:02:20 -07:00 committed by GitHub
parent 3caa09d21a
commit c74c20af29
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
datahub-upgrade/src/main/java/com/linkedin/datahub/upgrade/nocode/CleanupStep.java
View File

@ -1,34 +0,0 @@
package com.linkedin.datahub.upgrade.nocode;
import com.linkedin.datahub.upgrade.UpgradeCleanupStep;
import com.linkedin.datahub.upgrade.UpgradeContext;
import com.linkedin.datahub.upgrade.UpgradeResult;
import io.ebean.EbeanServer;
import java.util.function.BiConsumer;
/**
* Removes the Aspect Table on Upgrade Failure.
*/
public class CleanupStep implements UpgradeCleanupStep {
private final EbeanServer _server;
public CleanupStep(final EbeanServer server) {
_server = server;
}
@Override
public String id() {
return "CleanupStep";
}
@Override
public BiConsumer<UpgradeContext, UpgradeResult> executable() {
return (context, result) -> {
if (UpgradeResult.Result.FAILED.equals(result.result())) {
_server.execute(_server.createSqlUpdate("DROP TABLE metadata_aspect_v2"));
}
};
}
}

4
datahub-upgrade/src/main/java/com/linkedin/datahub/upgrade/nocode/NoCodeUpgrade.java
View File

@ -1,6 +1,5 @@
package com.linkedin.datahub.upgrade.nocode;
import com.google.common.collect.ImmutableList;
import com.linkedin.datahub.upgrade.Upgrade;
import com.linkedin.datahub.upgrade.UpgradeCleanupStep;
import com.linkedin.datahub.upgrade.UpgradeStep;
@ -8,6 +7,7 @@ import com.linkedin.metadata.entity.EntityService;
import com.linkedin.metadata.models.registry.SnapshotEntityRegistry;
import io.ebean.EbeanServer;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
public class NoCodeUpgrade implements Upgrade {
@ -48,7 +48,7 @@ public class NoCodeUpgrade implements Upgrade {
}
private List<UpgradeCleanupStep> buildCleanupSteps(final EbeanServer server) {
return ImmutableList.of(new CleanupStep(server));
return Collections.emptyList();
}
private List<UpgradeStep> buildUpgradeSteps(