yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-10-31 02:37:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(ui): Add option to remove asset from an Application (#14679)

Browse Source
This commit is contained in:
Saketh Varma 2025-09-09 16:17:21 -07:00 committed by GitHub
parent c731e725ff
commit c7ad3f45ea
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 55 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
datahub-web-react/src/app/entityV2/application/ApplicationEntitiesTab.tsx
View File

@ -26,6 +26,7 @@ export function ApplicationEntitiesTab() {
placeholderText="Filter assets..."
skipCache
applyView
shouldRefetch
/>
</SearchCardContext.Provider>
);

15
datahub-web-react/src/app/previewV2/DefaultPreviewCard.tsx
View File

@ -24,7 +24,12 @@ import ContextPath from '@app/previewV2/ContextPath';
import DefaultPreviewCardFooter from '@app/previewV2/DefaultPreviewCardFooter';
import EntityHeader from '@app/previewV2/EntityHeader';
import { ActionsAndStatusSection } from '@app/previewV2/shared';
import { useRemoveDataProductAssets, useRemoveDomainAssets, useRemoveGlossaryTermAssets } from '@app/previewV2/utils';
import {
useRemoveApplicationAssets,
useRemoveDataProductAssets,
useRemoveDomainAssets,
useRemoveGlossaryTermAssets,
} from '@app/previewV2/utils';
import { useSearchContext } from '@app/search/context/SearchContext';
import HoverCardAttributionDetails from '@app/sharedV2/propagation/HoverCardAttributionDetails';
import { AttributionDetails } from '@app/sharedV2/propagation/types';
@ -408,6 +413,7 @@ function useRemoveRelationship(entityType: EntityType) {
const { removeDomain } = useRemoveDomainAssets(setShouldRefetchEmbeddedListSearch);
const { removeTerm } = useRemoveGlossaryTermAssets(setShouldRefetchEmbeddedListSearch);
const { removeDataProduct } = useRemoveDataProductAssets(setShouldRefetchEmbeddedListSearch);
const { removeApplication } = useRemoveApplicationAssets(setShouldRefetchEmbeddedListSearch);
const previewData = usePreviewData();
const entityData = useEntityData();
@ -434,6 +440,13 @@ function useRemoveRelationship(entityType: EntityType) {
removeButtonText: showRemovalFromList ? removeText || 'Remove from Data Product' : null,
};
}
if (pageEntityType === EntityType.Application) {
return {
removeRelationship: () => (onRemove ? onRemove() : removeApplication(previewData?.urn)),
removeButtonText: showRemovalFromList ? removeText || 'Remove from Application' : null,
};
}
return {
removeRelationship: () => {},
removeButtonText: null,

40
datahub-web-react/src/app/previewV2/utils.ts
View File

@ -4,6 +4,7 @@ import { useEntityContext } from '@app/entity/shared/EntityContext';
import { EntityCapabilityType } from '@app/entityV2/Entity';
import { useBatchSetDataProductMutation } from '@src/graphql/dataProduct.generated';
import { useBatchSetApplicationMutation } from '@graphql/application.generated';
import { useRemoveTermMutation, useUnsetDomainMutation } from '@graphql/mutations.generated';
import { BrowsePathV2, GlobalTags, Owner } from '@types';
@ -154,6 +155,45 @@ export function useRemoveDataProductAssets(setShouldRefetchEmbeddedListSearch) {
return { removeDataProduct };
}
export function useRemoveApplicationAssets(setShouldRefetchEmbeddedListSearch) {
const [batchSetApplicationMutation] = useBatchSetApplicationMutation();
function handleApplication(urn) {
batchSetApplicationMutation({ variables: { input: { resourceUrns: [urn] } } })
.then(() => {
setTimeout(() => {
setShouldRefetchEmbeddedListSearch(true);
message.success({ content: 'Removed Application.', duration: 2 });
}, 2000);
})
.catch((e: unknown) => {
message.destroy();
if (e instanceof Error) {
message.error({
content: `Failed to remove application: ${e.message}`,
duration: 3,
});
}
});
}
const removeApplication = (urn) => {
Modal.confirm({
title: `Confirm Application Removal`,
content: `Are you sure you want to remove this application?`,
onOk() {
handleApplication(urn);
},
onCancel() {},
okText: 'Yes',
maskClosable: true,
closable: true,
});
};
return { removeApplication };
}
export const isDefaultBrowsePath = (browsePaths: BrowsePathV2) => {
return browsePaths.path?.length === 1 && browsePaths?.path[0]?.name === 'Default';
};