yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-12-26 17:37:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(timeline): fixes primary key change events (#11819)

Browse Source
This commit is contained in:
RyanHolstien 2024-11-07 13:20:01 -06:00 committed by GitHub
parent b3d3b636fc
commit ca063dd088
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 39 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

64
metadata-io/src/main/java/com/linkedin/metadata/timeline/eventgenerator/SchemaMetadataChangeEventGenerator.java
View File

@ -515,8 +515,8 @@ public class SchemaMetadataChangeEventGenerator extends EntityChangeEventGenerat
SchemaMetadata targetSchema,
Urn datasetUrn,
AuditStamp auditStamp) {
List<ChangeEvent> primaryKeyChangeEvents = new ArrayList<>();
if (changeCategories != null && changeCategories.contains(ChangeCategory.TECHNICAL_SCHEMA)) {
List<ChangeEvent> primaryKeyChangeEvents = new ArrayList<>();
Set<String> basePrimaryKeys =
(baseSchema != null && baseSchema.getPrimaryKeys() != null)
? new HashSet<>(baseSchema.getPrimaryKeys())
@ -529,51 +529,53 @@ public class SchemaMetadataChangeEventGenerator extends EntityChangeEventGenerat
basePrimaryKeys.stream()
.filter(key -> !targetPrimaryKeys.contains(key))
.collect(Collectors.toSet());
for (String removedBaseKeyField : removedBaseKeys) {
Urn schemaFieldUrn = getSchemaFieldUrn(datasetUrn.toString(), removedBaseKeyField);
primaryKeyChangeEvents.add(
DatasetSchemaFieldChangeEvent.schemaFieldChangeEventBuilder()
.category(ChangeCategory.TECHNICAL_SCHEMA)
.modifier(schemaFieldUrn.toString())
.fieldUrn(schemaFieldUrn)
.fieldPath(removedBaseKeyField)
.entityUrn(datasetUrn.toString())
.operation(ChangeOperation.MODIFY)
.semVerChange(SemanticChangeType.MAJOR)
.description(
BACKWARDS_INCOMPATIBLE_DESC
+ " removal of the primary key field '"
+ removedBaseKeyField
+ "'")
.auditStamp(auditStamp)
.modificationCategory(SchemaFieldModificationCategory.OTHER)
.build());
}
Set<String> addedTargetKeys =
targetPrimaryKeys.stream()
.filter(key -> !basePrimaryKeys.contains(key))
.collect(Collectors.toSet());
if (!removedBaseKeys.isEmpty() || !addedTargetKeys.isEmpty()) {
String keyChangeTarget;
// Just pick the first schema field we can find for the change event
if (!removedBaseKeys.isEmpty()) {
keyChangeTarget = removedBaseKeys.stream().findFirst().get();
} else {
keyChangeTarget = addedTargetKeys.stream().findFirst().get();
}
StringBuilder description =
new StringBuilder(BACKWARDS_INCOMPATIBLE_DESC + " a primary key constraint change.");
if (!removedBaseKeys.isEmpty()) {
description.append(" The following fields were removed:");
removedBaseKeys.forEach(
removedBaseKey -> description.append(" '").append(removedBaseKey).append("'"));
description.append(".");
}
if (!addedTargetKeys.isEmpty()) {
description.append(" The following fields were added:");
addedTargetKeys.forEach(
addedTargetKey -> description.append(" '").append(addedTargetKey).append("'"));
description.append(".");
}
for (String addedTargetKeyField : addedTargetKeys) {
Urn schemaFieldUrn = getSchemaFieldUrn(datasetUrn.toString(), addedTargetKeyField);
primaryKeyChangeEvents.add(
DatasetSchemaFieldChangeEvent.schemaFieldChangeEventBuilder()
.category(ChangeCategory.TECHNICAL_SCHEMA)
.fieldUrn(getSchemaFieldUrn(datasetUrn, keyChangeTarget))
.fieldPath(keyChangeTarget)
.modifier(getSchemaFieldUrn(datasetUrn, keyChangeTarget).toString())
.modifier(getSchemaFieldUrn(datasetUrn, addedTargetKeyField).toString())
.fieldUrn(schemaFieldUrn)
.fieldPath(addedTargetKeyField)
.entityUrn(datasetUrn.toString())
.operation(ChangeOperation.MODIFY)
.semVerChange(SemanticChangeType.MAJOR)
.description(description.toString())
.modificationCategory(SchemaFieldModificationCategory.OTHER)
.description(
BACKWARDS_INCOMPATIBLE_DESC
+ " addition of the primary key field '"
+ addedTargetKeyField
+ "'")
.auditStamp(auditStamp)
.modificationCategory(SchemaFieldModificationCategory.OTHER)
.build());
return primaryKeyChangeEvents;
}
}
return Collections.emptyList();
return primaryKeyChangeEvents;
}
@Override

12
metadata-io/src/test/java/com/linkedin/metadata/timeline/eventgenerator/SchemaMetadataChangeEventGeneratorTest.java
View File

@ -204,10 +204,10 @@ public class SchemaMetadataChangeEventGeneratorTest extends AbstractTestNGSpring
List<ChangeEvent> actual = test.getChangeEvents(urn, entity, aspect, from, to3, auditStamp);
compareDescriptions(
Set.of(
"A backwards incompatible change due to a primary key constraint change. "
+ "The following fields were removed: 'ID'. The following fields were added: 'ID2'."),
"A backwards incompatible change due to addition of the primary key field 'ID2'",
"A backwards incompatible change due to removal of the primary key field 'ID'"),
actual);
assertEquals(1, actual.size());
assertEquals(actual.size(), 2);
compareModificationCategories(Set.of(SchemaFieldModificationCategory.OTHER.toString()), actual);
}
@ -274,10 +274,10 @@ public class SchemaMetadataChangeEventGeneratorTest extends AbstractTestNGSpring
List<ChangeEvent> actual = test.getChangeEvents(urn, entity, aspect, from, to3, auditStamp);
compareDescriptions(
Set.of(
"A backwards incompatible change due to a primary key constraint change. "
+ "The following fields were removed: 'ID'. The following fields were added: 'ID2'."),
"A backwards incompatible change due to addition of the primary key field 'ID2'",
"A backwards incompatible change due to removal of the primary key field 'ID'"),
actual);
assertEquals(1, actual.size());
assertEquals(actual.size(), 2);
compareModificationCategories(Set.of(SchemaFieldModificationCategory.OTHER.toString()), actual);
Aspect<SchemaMetadata> to4 =