From cd59a87e7e8b20ccf13e443185c58bce8522973f Mon Sep 17 00:00:00 2001 From: v-tarasevich-blitz-brain Date: Tue, 25 Nov 2025 20:44:48 +0300 Subject: [PATCH] fix(cypress): optimyze summary about section tests (#15332) Co-authored-by: Victor Tarasevich Co-authored-by: Chris Collins --- .../cypress/cypress/e2e/summaryTab/aboutSection.js | 14 ++++++++++++++ .../cypress/e2e/summaryTab/dataProductSummary.js | 14 ++++---------- .../cypress/e2e/summaryTab/domainSummary.js | 14 ++++---------- .../cypress/e2e/summaryTab/glossaryNodeSummary.js | 14 ++++---------- .../cypress/e2e/summaryTab/glossaryTermSummary.js | 12 +++--------- 5 files changed, 29 insertions(+), 39 deletions(-) create mode 100644 smoke-test/tests/cypress/cypress/e2e/summaryTab/aboutSection.js diff --git a/smoke-test/tests/cypress/cypress/e2e/summaryTab/aboutSection.js b/smoke-test/tests/cypress/cypress/e2e/summaryTab/aboutSection.js new file mode 100644 index 0000000000..74956d3002 --- /dev/null +++ b/smoke-test/tests/cypress/cypress/e2e/summaryTab/aboutSection.js @@ -0,0 +1,14 @@ +import * as utils from "./utils"; + +describe("summary tab - about section", () => { + beforeEach(() => { + utils.setThemeV2AndSummaryTabFlags(true); + cy.login(); + cy.goToDataProduct("urn:li:dataProduct:testing"); + utils.goToSummaryTab(); + }); + + it("about section", () => { + utils.testAboutSection(); + }); +}); diff --git a/smoke-test/tests/cypress/cypress/e2e/summaryTab/dataProductSummary.js b/smoke-test/tests/cypress/cypress/e2e/summaryTab/dataProductSummary.js index 521a9731d3..000357ad71 100644 --- a/smoke-test/tests/cypress/cypress/e2e/summaryTab/dataProductSummary.js +++ b/smoke-test/tests/cypress/cypress/e2e/summaryTab/dataProductSummary.js @@ -13,7 +13,7 @@ describe("summary tab - data product", () => { utils.goToSummaryTab(); }); - it("data product - header section", () => { + it("summary tab", () => { utils.testPropertiesSection([ { name: "Created", type: "CREATED" }, { name: "Owners", type: "OWNERS" }, @@ -21,21 +21,15 @@ describe("summary tab - data product", () => { { name: "Tags", type: "TAGS", value: TEST_TAG_NAME }, { name: "Glossary Terms", type: "GLOSSARY_TERMS", value: TEST_TERM_NAME }, ]); - }); - it.skip("data product - description section", () => { - utils.testAboutSection(); - }); + utils.ensureAboutSectionIsVisible(); - it("data product - modules section", () => { - const defaultModules = [ + utils.testTemplateSection([ { type: "assets", name: "Assets", value: TEST_ASSET_NAME, }, - ]; - - utils.testTemplateSection(defaultModules); + ]); }); }); diff --git a/smoke-test/tests/cypress/cypress/e2e/summaryTab/domainSummary.js b/smoke-test/tests/cypress/cypress/e2e/summaryTab/domainSummary.js index a8b8454da8..9ad2630483 100644 --- a/smoke-test/tests/cypress/cypress/e2e/summaryTab/domainSummary.js +++ b/smoke-test/tests/cypress/cypress/e2e/summaryTab/domainSummary.js @@ -14,19 +14,15 @@ describe("summary tab - domain", () => { utils.goToSummaryTab(); }); - it("domain - header section", () => { + it("summary tab", () => { utils.testPropertiesSection([ { name: "Created", type: "CREATED" }, { name: "Owners", type: "OWNERS", dataTestId: `owner-${TEST_USER_URN}` }, ]); - }); - it.skip("domain - description section", () => { - utils.testAboutSection(); - }); + utils.ensureAboutSectionIsVisible(); - it("domain - modules section", () => { - const defaultModules = [ + utils.testTemplateSection([ { type: "assets", name: "Assets", @@ -44,8 +40,6 @@ describe("summary tab - domain", () => { name: "Data Products", value: TEST_DATA_PRODUCT_NAME, }, - ]; - - utils.testTemplateSection(defaultModules); + ]); }); }); diff --git a/smoke-test/tests/cypress/cypress/e2e/summaryTab/glossaryNodeSummary.js b/smoke-test/tests/cypress/cypress/e2e/summaryTab/glossaryNodeSummary.js index 0b150a2530..4e9b27e4fa 100644 --- a/smoke-test/tests/cypress/cypress/e2e/summaryTab/glossaryNodeSummary.js +++ b/smoke-test/tests/cypress/cypress/e2e/summaryTab/glossaryNodeSummary.js @@ -12,19 +12,15 @@ describe("summary tab - glossary node", () => { utils.goToSummaryTab(); }); - it("glossary node - header section", () => { + it("summary tab", () => { utils.testPropertiesSection([ { name: "Created", type: "CREATED" }, { name: "Owners", type: "OWNERS", dataTestId: `owner-${TEST_USER_URN}` }, ]); - }); - it.skip("glossary node - description section", () => { - utils.testAboutSection(); - }); + utils.ensureAboutSectionIsVisible(); - it("glossary node - modules section", () => { - const defaultModules = [ + utils.testTemplateSection([ { type: "hierarchy", // FYI: Contents module has different type in add module menu @@ -32,8 +28,6 @@ describe("summary tab - glossary node", () => { name: "Contents", value: TEST_GLOSSARY_TERM_NAME, }, - ]; - - utils.testTemplateSection(defaultModules); + ]); }); }); diff --git a/smoke-test/tests/cypress/cypress/e2e/summaryTab/glossaryTermSummary.js b/smoke-test/tests/cypress/cypress/e2e/summaryTab/glossaryTermSummary.js index d5789a858d..8793e992c6 100644 --- a/smoke-test/tests/cypress/cypress/e2e/summaryTab/glossaryTermSummary.js +++ b/smoke-test/tests/cypress/cypress/e2e/summaryTab/glossaryTermSummary.js @@ -19,14 +19,10 @@ describe("summary tab - glossary term", () => { { name: "Owners", type: "OWNERS", dataTestId: `owner-${TEST_USER_URN}` }, { name: "Domain", type: "DOMAIN", value: TEST_DOMAIN_NAME }, ]); - }); - it.skip("glossary term - description section", () => { - utils.testAboutSection(); - }); + utils.ensureAboutSectionIsVisible(); - it("glossary term - modules section", () => { - const defaultModules = [ + utils.testTemplateSection([ { type: "assets", name: "Assets", @@ -37,8 +33,6 @@ describe("summary tab - glossary term", () => { name: "Related Terms", value: TEST_RELATED_TERM_NAME, }, - ]; - - utils.testTemplateSection(defaultModules); + ]); }); });