yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-10-27 17:02:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1391 from cptran777/health-score-enhancements

Browse Source 
Add a tooltip for health score and remove more info from tooltip messages
This commit is contained in:
Charlie Tran 2018-09-18 14:05:15 -07:00 committed by GitHub
commit cd94e5af6f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 22 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
wherehows-frontend/app/controllers/Application.java
View File

@ -93,6 +93,8 @@ public class Application extends Controller {
Play.application().configuration().getString("links.wiki.complianceOwner", ""); Play.application().configuration().getString("links.wiki.complianceOwner", "");
private static final String WHZ_WIKI_LINKS__EXPORT_POLICY = private static final String WHZ_WIKI_LINKS__EXPORT_POLICY =
Play.application().configuration().getString("links.wiki.exportPolicy", ""); Play.application().configuration().getString("links.wiki.exportPolicy", "");
private static final String WHZ_WIKI_LINKS__METADATA_HEALTH =
Play.application().configuration().getString("links.wiki.metadataHealth", "");
private static final String WHZ_LINKS__JIT_ACL_CONTACT = private static final String WHZ_LINKS__JIT_ACL_CONTACT =
Play.application().configuration().getString("links.jitAcl.contact", ""); Play.application().configuration().getString("links.jitAcl.contact", "");
@ -266,6 +268,7 @@ public class Application extends Controller {
wikiLinks.put("jitAcl", WHZ_WIKI_LINKS__JIT_ACL_FAQ); wikiLinks.put("jitAcl", WHZ_WIKI_LINKS__JIT_ACL_FAQ);
wikiLinks.put("metadataCustomRegex", WHZ_WIKI_LINKS__METADATA_CUSTOM_REGEX); wikiLinks.put("metadataCustomRegex", WHZ_WIKI_LINKS__METADATA_CUSTOM_REGEX);
wikiLinks.put("exportPolicy", WHZ_WIKI_LINKS__EXPORT_POLICY); wikiLinks.put("exportPolicy", WHZ_WIKI_LINKS__EXPORT_POLICY);
wikiLinks.put("metadataHealth", WHZ_WIKI_LINKS__METADATA_HEALTH);
return wikiLinks; return wikiLinks;
} }

1
wherehows-web/app/styles/components/visualization/charts/_score-gauge.scss
View File

@ -14,6 +14,7 @@ $score-gauge-dimension: 128px;
font-size: 16px; font-size: 16px;
font-weight: 600; font-weight: 600;
margin: 0; margin: 0;
color: get-color(black);
} }
&-value { &-value {

11
wherehows-web/app/templates/components/datasets/containers/health-score-gauge.hbs
View File

@ -1,8 +1,13 @@
{{#if getHealthScoreTask.isIdle}} {{#if getHealthScoreTask.isIdle}}
{{visualization/charts/score-gauge {{#visualization/charts/score-gauge
class="dataset-health-score" class="dataset-health-score"
score=healthScore score=healthScore}}
title="Health Score:"}} Health Score:
{{more-info
link=@wikiLinks.metadataHealth
tooltip="Click for more information on Metadata Health Score"
}}
{{/visualization/charts/score-gauge}}
{{else}} {{else}}
{{pendulum-ellipsis-animation}} {{pendulum-ellipsis-animation}}
{{/if}} {{/if}}

5
wherehows-web/app/templates/components/more-info.hbs
View File

@ -2,12 +2,11 @@
<sup> <sup>
{{#if tooltip}} {{#if tooltip}}
<i data-title="{{tooltip}}" class="nacho-tooltip"> <i data-title="{{tooltip}}" class="nacho-tooltip">
More Info <span class="glyphicon glyphicon-question-sign"></span>
</i> </i>
{{else}} {{else}}
More Info <span class="glyphicon glyphicon-question-sign"></span>
{{/if}} {{/if}}
<span class="glyphicon glyphicon-question-sign"></span>
</sup> </sup>
</a> </a>

6
wherehows-web/app/templates/components/visualization/charts/score-gauge.hbs
View File

@ -1,7 +1,11 @@
{{high-charts chartOptions=(readonly chartOptions) content=(readonly chartData)}} {{high-charts chartOptions=(readonly chartOptions) content=(readonly chartData)}}
<div class="score-gauge__legend-wrapper"> <div class="score-gauge__legend-wrapper">
<h6 class="score-gauge__legend-title"> <h6 class="score-gauge__legend-title">
{{title}} {{#if hasBlock}}
{{yield}}
{{else}}
{{title}}
{{/if}}
</h6> </h6>
<span class="score-gauge__legend-value {{labelValueClass}}"> <span class="score-gauge__legend-value {{labelValueClass}}">
{{#if (eq scoreDisplay "percent")}} {{#if (eq scoreDisplay "percent")}}

4
wherehows-web/app/templates/datasets/dataset.hbs
View File

@ -62,7 +62,9 @@
avatarEntityProps=avatarEntityProps avatarEntityProps=avatarEntityProps
class="dataset-owner-list"}} class="dataset-owner-list"}}
{{datasets/containers/health-score-gauge urn=encodedUrn}} {{#link-to "datasets.dataset.health" encodedUrn}}
{{datasets/containers/health-score-gauge urn=encodedUrn wikiLinks=wikiLinks}}
{{/link-to}}
{{/if}} {{/if}}
</div> </div>