diff --git a/wherehows-web/app/constants/datasets/owner.ts b/wherehows-web/app/constants/datasets/owner.ts index a33e197e25..1fa92b09d5 100644 --- a/wherehows-web/app/constants/datasets/owner.ts +++ b/wherehows-web/app/constants/datasets/owner.ts @@ -25,13 +25,10 @@ const minRequiredConfirmedOwners = 2; const ownerAlreadyExists = ( owners: Array, { userName, source }: Pick -): boolean => { - /* prettier-ignore */ - // https://github.com/prettier/prettier/issues/3805 - return (userName && source) +): boolean => + userName && source ? owners.map(({ userName, source }) => `${userName}:${source}`).includes(`${userName}:${source}`) : false; -}; // overloads function updateOwner(owners: Array, owner: IOwner, props: IOwner): void | Array; diff --git a/wherehows-web/package.json b/wherehows-web/package.json index 97393b3434..e1dfea4778 100644 --- a/wherehows-web/package.json +++ b/wherehows-web/package.json @@ -19,7 +19,7 @@ "eslint-check-prettier-conflict": "./node_modules/.bin/eslint --print-config .eslintrc.js | ./node_modules/.bin/eslint-config-prettier-check" }, "devDependencies": { - "@types/ember": "2.8.5", + "@types/ember": "^2.8.7", "@types/ember-testing-helpers": "^0.0.3", "@types/lodash": "^4.14.83", "@types/rsvp": "^4.0.0", diff --git a/wherehows-web/tsconfig.json b/wherehows-web/tsconfig.json index 485fe7f02f..21a92bdbcd 100644 --- a/wherehows-web/tsconfig.json +++ b/wherehows-web/tsconfig.json @@ -10,6 +10,7 @@ "module": "es6", "allowSyntheticDefaultImports": true, "noEmit": true, + "noEmitOnError": true, "noImplicitThis": true, "noImplicitAny": true, "strictNullChecks": true, diff --git a/wherehows-web/yarn.lock b/wherehows-web/yarn.lock index 82082e94cb..e0dcecefac 100644 --- a/wherehows-web/yarn.lock +++ b/wherehows-web/yarn.lock @@ -141,9 +141,9 @@ "@types/jquery" "*" "@types/rsvp" "*" -"@types/ember@2.8.5": - version "2.8.5" - resolved "https://registry.yarnpkg.com/@types/ember/-/ember-2.8.5.tgz#66f3ced02924e403e80a37eeb3e5524165db0a41" +"@types/ember@^2.8.7": + version "2.8.7" + resolved "https://registry.yarnpkg.com/@types/ember/-/ember-2.8.7.tgz#9a4e73998aef5b39b671a2abe31560d7b76118db" dependencies: "@types/handlebars" "*" "@types/jquery" "*"