update types version for ember. adds noEmitOnError for ts sources

This commit is contained in:
Seyi Adebajo 2018-01-25 10:42:43 -08:00
parent 432de27d9b
commit cec37f49e6
4 changed files with 7 additions and 9 deletions

View File

@ -25,13 +25,10 @@ const minRequiredConfirmedOwners = 2;
const ownerAlreadyExists = ( const ownerAlreadyExists = (
owners: Array<IOwner>, owners: Array<IOwner>,
{ userName, source }: Pick<IOwner, 'userName' | 'source'> { userName, source }: Pick<IOwner, 'userName' | 'source'>
): boolean => { ): boolean =>
/* prettier-ignore */ userName && source
// https://github.com/prettier/prettier/issues/3805
return (userName && source)
? owners.map(({ userName, source }) => `${userName}:${source}`).includes(`${userName}:${source}`) ? owners.map(({ userName, source }) => `${userName}:${source}`).includes(`${userName}:${source}`)
: false; : false;
};
// overloads // overloads
function updateOwner(owners: Array<IOwner>, owner: IOwner, props: IOwner): void | Array<IOwner>; function updateOwner(owners: Array<IOwner>, owner: IOwner, props: IOwner): void | Array<IOwner>;

View File

@ -19,7 +19,7 @@
"eslint-check-prettier-conflict": "./node_modules/.bin/eslint --print-config .eslintrc.js | ./node_modules/.bin/eslint-config-prettier-check" "eslint-check-prettier-conflict": "./node_modules/.bin/eslint --print-config .eslintrc.js | ./node_modules/.bin/eslint-config-prettier-check"
}, },
"devDependencies": { "devDependencies": {
"@types/ember": "2.8.5", "@types/ember": "^2.8.7",
"@types/ember-testing-helpers": "^0.0.3", "@types/ember-testing-helpers": "^0.0.3",
"@types/lodash": "^4.14.83", "@types/lodash": "^4.14.83",
"@types/rsvp": "^4.0.0", "@types/rsvp": "^4.0.0",

View File

@ -10,6 +10,7 @@
"module": "es6", "module": "es6",
"allowSyntheticDefaultImports": true, "allowSyntheticDefaultImports": true,
"noEmit": true, "noEmit": true,
"noEmitOnError": true,
"noImplicitThis": true, "noImplicitThis": true,
"noImplicitAny": true, "noImplicitAny": true,
"strictNullChecks": true, "strictNullChecks": true,

View File

@ -141,9 +141,9 @@
"@types/jquery" "*" "@types/jquery" "*"
"@types/rsvp" "*" "@types/rsvp" "*"
"@types/ember@2.8.5": "@types/ember@^2.8.7":
version "2.8.5" version "2.8.7"
resolved "https://registry.yarnpkg.com/@types/ember/-/ember-2.8.5.tgz#66f3ced02924e403e80a37eeb3e5524165db0a41" resolved "https://registry.yarnpkg.com/@types/ember/-/ember-2.8.7.tgz#9a4e73998aef5b39b671a2abe31560d7b76118db"
dependencies: dependencies:
"@types/handlebars" "*" "@types/handlebars" "*"
"@types/jquery" "*" "@types/jquery" "*"