yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-11-10 16:32:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui ingestion): fixing issue where stale fields could stick around when changing recipes (#8421)

Browse Source
This commit is contained in:
Gabe Lyons 2023-07-17 13:22:37 -07:00 committed by GitHub
parent 620d23d623
commit cf8e44b69a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
datahub-web-react/src/app/ingest/source/builder/DefineRecipeStep.tsx
View File

@ -45,12 +45,14 @@ export const DefineRecipeStep = ({ state, updateState, goTo, prev, ingestionSour
const placeholderRecipe = getPlaceholderRecipe(ingestionSources, type); const placeholderRecipe = getPlaceholderRecipe(ingestionSources, type);
const [stagedRecipeYml, setStagedRecipeYml] = useState(existingRecipeYaml || placeholderRecipe); const [stagedRecipeYml, setStagedRecipeYml] = useState(existingRecipeYaml || placeholderRecipe);
const [stagedRecipeName, setStagedRecipeName] = useState(state.name);
useEffect(() => { useEffect(() => {
if (existingRecipeYaml) { if (existingRecipeYaml) {
setStagedRecipeName(state.name);
setStagedRecipeYml(existingRecipeYaml); setStagedRecipeYml(existingRecipeYaml);
} }
}, [existingRecipeYaml]); }, [existingRecipeYaml, state.name]);
const [stepComplete, setStepComplete] = useState(false); const [stepComplete, setStepComplete] = useState(false);
@ -97,6 +99,7 @@ export const DefineRecipeStep = ({ state, updateState, goTo, prev, ingestionSour
if (type && CONNECTORS_WITH_FORM.has(type)) { if (type && CONNECTORS_WITH_FORM.has(type)) {
return ( return (
<RecipeBuilder <RecipeBuilder
key={stagedRecipeName}
state={state} state={state}
isEditing={isEditing} isEditing={isEditing}
displayRecipe={displayRecipe} displayRecipe={displayRecipe}