yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-08-12 11:17:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(sql-parsing): improve error handling (#4862)

Browse Source
This commit is contained in:
Aseem Bansal 2022-05-10 15:48:54 +05:30 committed by GitHub
parent e697b89bee
commit d0cdadbb3f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
metadata-ingestion/src/datahub/utilities/sql_lineage_parser_impl.py
View File

@ -2,7 +2,7 @@ import logging
import re
import unittest
import unittest.mock
from typing import Dict, List, Set
from typing import Dict, List, Optional, Set
from sqllineage.core.holders import Column, SQLLineageHolder
from sqllineage.exceptions import SQLLineageException
@ -64,7 +64,8 @@ class SqlLineageSQLParserImpl:
logger.debug(f"Rewrote original query {original_sql_query} as {sql_query}")
self._sql = sql_query
self._stmt_holders: Optional[List[LineageAnalyzer]] = None
self._sql_holder: Optional[SQLLineageHolder] = None
try:
self._stmt = [
s
@ -97,6 +98,9 @@ class SqlLineageSQLParserImpl:
def get_tables(self) -> List[str]:
result: List[str] = list()
if self._sql_holder is None:
logger.error("sql holder not present so cannot get tables")
return result
for table in self._sql_holder.source_tables:
table_normalized = re.sub(r"^<default>.", "", str(table))
result.append(str(table_normalized))
@ -115,6 +119,9 @@ class SqlLineageSQLParserImpl:
return result
def get_columns(self) -> List[str]:
if self._sql_holder is None:
logger.error("sql holder not present so cannot get columns")
return []
graph: DiGraph = self._sql_holder.graph # For mypy attribute checking
column_nodes = [n for n in graph.nodes if isinstance(n, Column)]
column_graph = graph.subgraph(column_nodes)