yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-10-31 02:37:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui) Fix re-expanding entity name after sidebar opens/closes (#14925)

Browse Source
This commit is contained in:
Chris Collins 2025-10-03 14:00:56 -04:00 committed by GitHub
parent 37c9ed8564
commit d0e0e20cff
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
datahub-web-react/src/app/entityV2/shared/containers/profile/header/EntityName.tsx
View File

@ -1,5 +1,5 @@
import { Typography, message } from 'antd';
import React, { useEffect, useState } from 'react';
import React, { useContext, useEffect, useState } from 'react';
import { Link } from 'react-router-dom';
import styled from 'styled-components/macro';
@ -11,6 +11,8 @@ import { useGlossaryEntityData } from '@app/entityV2/shared/GlossaryEntityContex
import { getParentNodeToUpdate, updateGlossarySidebar } from '@app/glossary/utils';
import { useModulesContext } from '@app/homeV3/module/context/ModulesContext';
import CompactContext from '@app/shared/CompactContext';
import usePrevious from '@app/shared/usePrevious';
import EntitySidebarContext from '@app/sharedV2/EntitySidebarContext';
import { useEntityRegistry } from '@app/useEntityRegistry';
import { getColor } from '@src/alchemy-components/theme/utils';
import { useEmbeddedProfileLinkProps } from '@src/app/shared/useEmbeddedProfileLinkProps';
@ -53,6 +55,7 @@ interface Props {
function EntityName(props: Props) {
const { isNameEditable } = props;
const { isClosed: isSidebarClosed } = useContext(EntitySidebarContext);
const refetch = useRefetch();
const entityRegistry = useEntityRegistry();
const { isInGlossaryContext, urnsToUpdate, setUrnsToUpdate } = useGlossaryEntityData();
@ -128,8 +131,19 @@ function EntityName(props: Props) {
});
};
// Note: Bug with editable + ellipsis, if text is compressed, it never grows back
// imo we should just get rid of this editing feature, it looks bad
// The following handles bug where sidebar opening causes ellipses and closing it doesn't show full name again
const [key, setKey] = useState(0);
const previousIsSidebarClosed = usePrevious(isSidebarClosed);
useEffect(() => {
if (isSidebarClosed !== previousIsSidebarClosed) {
// timeout to wait for sidebar to fully re-open
setTimeout(() => {
setKey((prev) => prev + 1);
}, 200);
}
}, [isSidebarClosed, previousIsSidebarClosed]);
const Title = isNameEditable ? (
<EntityTitle
disabled={isMutatingName}
@ -142,7 +156,7 @@ function EntityName(props: Props) {
ellipsis={{
tooltip: { showArrow: false, color: 'white', overlayInnerStyle: { color: colors.gray[1700] } },
}}
key={updatedName}
key={`${updatedName}-${key}`}
>
{updatedName}
</EntityTitle>
@ -152,6 +166,7 @@ function EntityName(props: Props) {
ellipsis={{
tooltip: { showArrow: false, color: 'white', overlayInnerStyle: { color: colors.gray[1700] } },
}}
key={`${entityName}-${key}`}
>
{entityName}
</EntityTitle>