yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-06-27 05:03:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(web) move access management tab to the front (#13092)

Browse Source
This commit is contained in:
Jay 2025-05-22 13:03:35 -04:00 committed by GitHub
parent 550a801196
commit d2578b7d34
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 26 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
datahub-web-react/src/app/entity/container/ContainerEntity.tsx
View File

@ -91,11 +91,7 @@ export class ContainerEntity implements Entity<Container> {
component: DocumentationTab,
},
{
name: 'Properties',
component: PropertiesTab,
},
{
name: 'Access Management',
name: 'Access',
component: AccessManagement,
display: {
visible: (_, container: GetContainerQuery) => {
@ -111,6 +107,10 @@ export class ContainerEntity implements Entity<Container> {
},
},
},
{
name: 'Properties',
component: PropertiesTab,
},
]}
sidebarSections={this.getSidebarSections()}
/>

24
datahub-web-react/src/app/entity/dataset/DatasetEntity.tsx
View File

@ -148,6 +148,18 @@ export class DatasetEntity implements Entity<Dataset> {
name: 'Lineage',
component: LineageTab,
},
{
name: 'Access',
component: AccessManagement,
display: {
visible: (_, _1) => this.appconfig().config.featureFlags.showAccessManagement,
enabled: (_, dataset: GetDatasetQuery) => {
const accessAspect = dataset?.dataset?.access;
const rolesList = accessAspect?.roles;
return !!accessAspect && !!rolesList && rolesList.length > 0;
},
},
},
{
name: 'Properties',
component: PropertiesTab,
@ -203,18 +215,6 @@ export class DatasetEntity implements Entity<Dataset> {
},
},
},
{
name: 'Access Management',
component: AccessManagement,
display: {
visible: (_, _1) => this.appconfig().config.featureFlags.showAccessManagement,
enabled: (_, dataset: GetDatasetQuery) => {
const accessAspect = dataset?.dataset?.access;
const rolesList = accessAspect?.roles;
return !!accessAspect && !!rolesList && rolesList.length > 0;
},
},
},
{
name: 'Incidents',
component: IncidentTab,

18
datahub-web-react/src/app/entityV2/dataset/DatasetEntity.tsx
View File

@ -189,6 +189,15 @@ export class DatasetEntity implements Entity<Dataset> {
component: LineageTab,
icon: PartitionOutlined,
},
{
name: 'Access',
component: AccessManagement,
icon: UnlockOutlined,
display: {
visible: (_, _1) => this.appconfig().config.featureFlags.showAccessManagement,
enabled: (_, _2) => true,
},
},
{
name: 'Properties',
component: PropertiesTab,
@ -254,15 +263,6 @@ export class DatasetEntity implements Entity<Dataset> {
},
},
},
{
name: 'Access Management',
component: AccessManagement,
icon: UnlockOutlined,
display: {
visible: (_, _1) => this.appconfig().config.featureFlags.showAccessManagement,
enabled: (_, _2) => true,
},
},
{
name: 'Incidents',
icon: WarningOutlined,