yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-10-29 09:52:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove see more less from export policy and fix typo for save disable check for dataset fields

Browse Source
This commit is contained in:
cptran777 2018-09-10 16:07:47 -07:00
parent 78e7d4a049
commit d2eb90ad6b
3 changed files with 5 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
wherehows-web/app/components/dataset-compliance.ts
View File

@ -1496,6 +1496,9 @@ export default class DatasetCompliance extends Component {
const setSaveFlag = (flag = false): boolean => set(this, 'isSaving', flag); const setSaveFlag = (flag = false): boolean => set(this, 'isSaving', flag);
const editTarget = get(this, 'editTarget'); const editTarget = get(this, 'editTarget');
console.log('saving compliance');
console.log(get(this, 'changeSetNeedsReview'));
try { try {
const isSaving = true; const isSaving = true;
const onSave = get(this, 'onSave'); const onSave = get(this, 'onSave');

2
wherehows-web/app/templates/components/dataset-compliance.hbs
View File

@ -44,7 +44,7 @@
title="{{unless isDatasetFullyClassified title="{{unless isDatasetFullyClassified
'Ensure you have provided a yes/no value for all dataset tags' 'Ensure you have provided a yes/no value for all dataset tags'
'Save'}}" 'Save'}}"
onclick={{action metrics.trackOnAction (action "saveCompliance")}} disabled={{and (eq edit ComplianceEdit.CompliancePolicy) changeSetNeedsReview}}> onclick={{action metrics.trackOnAction (action "saveCompliance")}} disabled={{and (eq editTarget ComplianceEdit.CompliancePolicy) changeSetNeedsReview}}>
Save Save
</button> </button>
{{/track-ui-event}} {{/track-ui-event}}

24
wherehows-web/app/templates/components/datasets/compliance/export-policy.hbs
View File

@ -52,7 +52,7 @@
{{/table.head}} {{/table.head}}
{{#table.body as |body|}} {{#table.body as |body|}}
{{#each (if shouldShowAllExportPolicyData table.data (filter-by "value" true table.data)) as |classification|}} {{#each table.data as |classification|}}
{{#body.row as |row|}} {{#body.row as |row|}}
{{#row.cell class="dataset-field-content__prompt"}} {{#row.cell class="dataset-field-content__prompt"}}
<span class="dataset-tag-container"> <span class="dataset-tag-container">
@ -127,26 +127,4 @@
{{/each}} {{/each}}
{{/table.body}} {{/table.body}}
{{#if (not isEditing)}}
{{#table.foot}}
<td colspan="2" class="text-center">
<button
{{action "onShowAllExportPolicyData"}}
class="nacho-button--large nacho-button--tertiary">
{{#if shouldShowMorePolicyData}}
See Less <span class="fa fa-caret-up" aria-label="See Less Types of Data"></span>
{{else}}
See More <span class="fa fa-caret-down" aria-label="See More Types of Data"></span>
{{/if}}
</button>
</td>
{{/table.foot}}
{{/if}}
{{/dataset-table}} {{/dataset-table}}