From d733363bedf6d3558751e2ec28102f2468333620 Mon Sep 17 00:00:00 2001 From: Harshal Sheth Date: Thu, 20 Jul 2023 11:05:25 -0700 Subject: [PATCH] chore(ingest): drop bigquery-beta and snowflake-beta aliases (#8451) --- docs/how/updating-datahub.md | 1 + metadata-ingestion/setup.py | 11 ----------- .../ingestion/source/source_registry.py | 19 ------------------- 3 files changed, 1 insertion(+), 30 deletions(-) diff --git a/docs/how/updating-datahub.md b/docs/how/updating-datahub.md index b8ecd689ce..03b3d763ed 100644 --- a/docs/how/updating-datahub.md +++ b/docs/how/updating-datahub.md @@ -14,6 +14,7 @@ This file documents any backwards-incompatible changes in DataHub and assists pe `profile_table_level_only` together with `include_field_xyz` config options to ingest certain column-level metrics. Instead, set `profile_table_level_only` to `false` and individually enable / disable desired field metrics. +- #8451: The `bigquery-beta` and `snowflake-beta` source aliases have been dropped. Use `bigquery` and `snowflake` as the source type instead. ### Potential Downtime diff --git a/metadata-ingestion/setup.py b/metadata-ingestion/setup.py index 36f4151df0..04bc03a236 100644 --- a/metadata-ingestion/setup.py +++ b/metadata-ingestion/setup.py @@ -292,14 +292,6 @@ plugins: Dict[str, Set[str]] = { "sqlalchemy-bigquery>=1.4.1", "google-cloud-datacatalog-lineage==0.2.2", }, - "bigquery-beta": sql_common - | bigquery_common - | { - *sqllineage_lib, - *sqlglot_lib, - "sql_metadata", - "sqlalchemy-bigquery>=1.4.1", - }, # deprecated, but keeping the extra for backwards compatibility "clickhouse": sql_common | clickhouse_common, "clickhouse-usage": sql_common | usage_common | clickhouse_common, "datahub-lineage-file": set(), @@ -370,9 +362,6 @@ plugins: Dict[str, Set[str]] = { "sagemaker": aws_common, "salesforce": {"simple-salesforce"}, "snowflake": snowflake_common | usage_common | sqlglot_lib, - "snowflake-beta": ( - snowflake_common | usage_common | sqlglot_lib - ), # deprecated, but keeping the extra for backwards compatibility "sqlalchemy": sql_common, "superset": { "requests", diff --git a/metadata-ingestion/src/datahub/ingestion/source/source_registry.py b/metadata-ingestion/src/datahub/ingestion/source/source_registry.py index 23fe1bd3ba..37f088bcd7 100644 --- a/metadata-ingestion/src/datahub/ingestion/source/source_registry.py +++ b/metadata-ingestion/src/datahub/ingestion/source/source_registry.py @@ -8,25 +8,6 @@ source_registry = PluginRegistry[Source]() source_registry.register_from_entrypoint("datahub.ingestion.source.plugins") # Deprecations. -source_registry.register_alias( - "snowflake-beta", - "snowflake", - lambda: warnings.warn( - "source type snowflake-beta is deprecated, use snowflake instead", - ConfigurationWarning, - stacklevel=3, - ), -) -source_registry.register_alias( - "bigquery-beta", - "bigquery", - lambda: warnings.warn( - "source type bigquery-beta is deprecated, use bigquery instead", - ConfigurationWarning, - stacklevel=3, - ), -) - source_registry.register_alias( "redshift-usage", "redshift-usage-legacy",