yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-12-12 10:35:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixes edge case issue: when a user clicks the fieldName without a source would not render the input box. increases the width for dropdown filter in search-bar component

Browse Source
This commit is contained in:
Seyi Adebajo 2017-04-05 18:35:11 -07:00 committed by Mars Lan
parent 74cbbf0263
commit d9df311f40
2 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
wherehows-web/app/components/dataset-author.js
View File

@ -74,11 +74,10 @@ export default Component.extend({
// Returns a list of owners with truthy value for their confirmedBy attribute,
// i.e. they confirmedBy contains a userName and
// type is `Owner` and idType is `USER`.
confirmedOwners: computed('owners.[]', function () {
confirmedOwners: computed('owners.[]', function() {
return getWithDefault(this, 'owners', []).filter(
({ confirmedBy, type, idType }) => confirmedBy &&
type === 'Owner' &&
idType === 'USER'
({ confirmedBy, type, idType }) =>
confirmedBy && type === 'Owner' && idType === 'USER'
);
}),
@ -98,10 +97,10 @@ export default Component.extend({
* @type {Ember.ComputedProperty}
* @requires _defaultOwnerUserName
*/
userNameInvalid: computed('owners.[]', function () {
return getWithDefault(this, 'owners', [])
.filter(({ userName }) => userName === _defaultOwnerUserName)
.length > 0;
userNameInvalid: computed('owners.[]', function() {
return getWithDefault(this, 'owners', []).filter(
({ userName }) => userName === _defaultOwnerUserName
).length > 0;
}),
didInsertElement() {
@ -190,10 +189,12 @@ export default Component.extend({
* wrapping TD element, which handles the bubbled Mouse click on the
* label
*/
willEditUserName({ source = "" }, { currentTarget: { classList } }) {
willEditUserName({ source = '' }, { currentTarget: { classList } }) {
// Add the className cached in `userNameEditableClass`. This renders
// the input element in the DOM, and removes the label from layout
if (!source.includes("SCM") && typeof classList.add === 'function') {
if (
source && !source.includes('SCM') && typeof classList.add === 'function'
) {
classList.add(userNameEditableClass);
}
},

2
wherehows-web/app/styles/components/nacho/_nacho-global-search.scss
View File

@ -12,7 +12,7 @@ $height: 40px;
* Rules for the search bar filter component
*/
&__filter {
width: 65px;
width: 75px;
display: inline-flex;
white-space: nowrap;
overflow: hidden;