yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-11-01 03:09:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Corrects old references to previous dataset type

Browse Source
This commit is contained in:
Seyi Adebajo 2020-02-02 22:19:58 -08:00 committed by Seyi Adebajo
parent 7952a69f8b
commit dab61485c5
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
datahub-web/@datahub/data-models/addon/api/dataset/dataset.ts
View File

@ -20,7 +20,7 @@ export const datasetUrlByUrn = (urn: string): string => `${datasetUrlRoot(ApiVer
/**
* Queries the Feature endpoint with the urn provided to retrieve entity information
* @param {string} urn
* @returns {Promise<IDatasetApiView>}
* @returns {Promise<IDatasetEntity>}
*/
export const readDataset = (urn: string): Promise<IDatasetEntity> =>
getJSON({ url: datasetUrlByUrn(urn) }).then(({ dataset }): IDatasetEntity => dataset);

4
datahub-web/@datahub/data-models/tests/dummy/app/constants/mocks/dataset.ts
View File

@ -1,8 +1,8 @@
import { IDatasetApiView } from '@datahub/metadata-types/types/entity/dataset/dataset-entity';
import { IDatasetEntity } from '@datahub/metadata-types/types/entity/dataset/dataset-entity';
import { FabricType } from '@datahub/metadata-types/constants/common/fabric-type';
import { DatasetPlatform } from '@datahub/metadata-types/constants/entity/dataset/platform';
export const mockDatasetEntity = (overrideProps: Partial<IDatasetApiView> = {}): IDatasetApiView => ({
export const mockDatasetEntity = (overrideProps: Partial<IDatasetEntity> = {}): IDatasetEntity => ({
uri: 'urn',
createdTime: 8675309,
decommissionTime: 8675309,

4
datahub-web/@datahub/data-models/tests/unit/utils/api/dataset/dataset-test.ts
View File

@ -3,7 +3,7 @@ import { module } from 'qunit';
import test from 'ember-sinon-qunit/test-support/test';
import { setupSinonTest } from 'dummy/tests/helpers/setup-sinon-test';
import { readDataset } from '@datahub/data-models/api/dataset/dataset';
import { IDatasetApiView } from '@datahub/metadata-types/types/entity/dataset/dataset-entity';
import { IDatasetEntity } from '@datahub/metadata-types/types/entity/dataset/dataset-entity';
import { mockDatasetEntity } from 'dummy/constants/mocks/dataset';
module('Unit | Utility | api/dataset/dataset', function(hooks) {
@ -11,7 +11,7 @@ module('Unit | Utility | api/dataset/dataset', function(hooks) {
test('readDataset() is a thennable', async function(this: SinonTestContext, assert) {
assert.expect(2);
const testDataset: IDatasetApiView = mockDatasetEntity();
const testDataset: IDatasetEntity = mockDatasetEntity();
const setupValue = setupSinonTest(this);
const response = readDataset('urn');

4
datahub-web/@datahub/datasets-core/tests/dummy/mirage/helpers/get-dataset-entity.ts
View File

@ -1,6 +1,6 @@
import { IFunctionRouteHandler } from '@datahub/utils/types/vendor/ember-cli-mirage-deprecated';
import { IMirageDatasetCoreSchema } from '@datahub/datasets-core/types/vendor/mirage-for-datasets';
import { IDatasetApiView } from '@datahub/metadata-types/types/entity/dataset/dataset-entity';
import { IDatasetEntity } from '@datahub/metadata-types/types/entity/dataset/dataset-entity';
/**
* Mirage response for the dataset entity getter API request, used in the mirage router file for a more
@ -9,7 +9,7 @@ import { IDatasetApiView } from '@datahub/metadata-types/types/entity/dataset/da
export const getDatasetEntity = function(
this: IFunctionRouteHandler,
schema: IMirageDatasetCoreSchema
): { dataset: IDatasetApiView } {
): { dataset: IDatasetEntity } {
const datasetInfo = schema.db.datasetViews[0];
return { dataset: this.serialize(datasetInfo) };
};