diff --git a/datahub-web/@datahub/data-models/addon/api/dataset/dataset.ts b/datahub-web/@datahub/data-models/addon/api/dataset/dataset.ts index 886727ec2e..5ce39db8fd 100644 --- a/datahub-web/@datahub/data-models/addon/api/dataset/dataset.ts +++ b/datahub-web/@datahub/data-models/addon/api/dataset/dataset.ts @@ -20,7 +20,7 @@ export const datasetUrlByUrn = (urn: string): string => `${datasetUrlRoot(ApiVer /** * Queries the Feature endpoint with the urn provided to retrieve entity information * @param {string} urn - * @returns {Promise} + * @returns {Promise} */ export const readDataset = (urn: string): Promise => getJSON({ url: datasetUrlByUrn(urn) }).then(({ dataset }): IDatasetEntity => dataset); diff --git a/datahub-web/@datahub/data-models/tests/dummy/app/constants/mocks/dataset.ts b/datahub-web/@datahub/data-models/tests/dummy/app/constants/mocks/dataset.ts index 576c09058d..8ba2971123 100644 --- a/datahub-web/@datahub/data-models/tests/dummy/app/constants/mocks/dataset.ts +++ b/datahub-web/@datahub/data-models/tests/dummy/app/constants/mocks/dataset.ts @@ -1,8 +1,8 @@ -import { IDatasetApiView } from '@datahub/metadata-types/types/entity/dataset/dataset-entity'; +import { IDatasetEntity } from '@datahub/metadata-types/types/entity/dataset/dataset-entity'; import { FabricType } from '@datahub/metadata-types/constants/common/fabric-type'; import { DatasetPlatform } from '@datahub/metadata-types/constants/entity/dataset/platform'; -export const mockDatasetEntity = (overrideProps: Partial = {}): IDatasetApiView => ({ +export const mockDatasetEntity = (overrideProps: Partial = {}): IDatasetEntity => ({ uri: 'urn', createdTime: 8675309, decommissionTime: 8675309, diff --git a/datahub-web/@datahub/data-models/tests/unit/utils/api/dataset/dataset-test.ts b/datahub-web/@datahub/data-models/tests/unit/utils/api/dataset/dataset-test.ts index 4532841dfb..ff5b6936be 100644 --- a/datahub-web/@datahub/data-models/tests/unit/utils/api/dataset/dataset-test.ts +++ b/datahub-web/@datahub/data-models/tests/unit/utils/api/dataset/dataset-test.ts @@ -3,7 +3,7 @@ import { module } from 'qunit'; import test from 'ember-sinon-qunit/test-support/test'; import { setupSinonTest } from 'dummy/tests/helpers/setup-sinon-test'; import { readDataset } from '@datahub/data-models/api/dataset/dataset'; -import { IDatasetApiView } from '@datahub/metadata-types/types/entity/dataset/dataset-entity'; +import { IDatasetEntity } from '@datahub/metadata-types/types/entity/dataset/dataset-entity'; import { mockDatasetEntity } from 'dummy/constants/mocks/dataset'; module('Unit | Utility | api/dataset/dataset', function(hooks) { @@ -11,7 +11,7 @@ module('Unit | Utility | api/dataset/dataset', function(hooks) { test('readDataset() is a thennable', async function(this: SinonTestContext, assert) { assert.expect(2); - const testDataset: IDatasetApiView = mockDatasetEntity(); + const testDataset: IDatasetEntity = mockDatasetEntity(); const setupValue = setupSinonTest(this); const response = readDataset('urn'); diff --git a/datahub-web/@datahub/datasets-core/tests/dummy/mirage/helpers/get-dataset-entity.ts b/datahub-web/@datahub/datasets-core/tests/dummy/mirage/helpers/get-dataset-entity.ts index 6cdac23d38..d3d2acc01c 100644 --- a/datahub-web/@datahub/datasets-core/tests/dummy/mirage/helpers/get-dataset-entity.ts +++ b/datahub-web/@datahub/datasets-core/tests/dummy/mirage/helpers/get-dataset-entity.ts @@ -1,6 +1,6 @@ import { IFunctionRouteHandler } from '@datahub/utils/types/vendor/ember-cli-mirage-deprecated'; import { IMirageDatasetCoreSchema } from '@datahub/datasets-core/types/vendor/mirage-for-datasets'; -import { IDatasetApiView } from '@datahub/metadata-types/types/entity/dataset/dataset-entity'; +import { IDatasetEntity } from '@datahub/metadata-types/types/entity/dataset/dataset-entity'; /** * Mirage response for the dataset entity getter API request, used in the mirage router file for a more @@ -9,7 +9,7 @@ import { IDatasetApiView } from '@datahub/metadata-types/types/entity/dataset/da export const getDatasetEntity = function( this: IFunctionRouteHandler, schema: IMirageDatasetCoreSchema -): { dataset: IDatasetApiView } { +): { dataset: IDatasetEntity } { const datasetInfo = schema.db.datasetViews[0]; return { dataset: this.serialize(datasetInfo) }; };