From dbd57c972f79ae1469adc0c8bde77fd6821fb819 Mon Sep 17 00:00:00 2001 From: david-leifker <114954101+david-leifker@users.noreply.github.com> Date: Tue, 28 Jan 2025 15:59:01 -0600 Subject: [PATCH] fix(ci): fix datahub-ingestion release/tag publishing (#12466) --- .github/workflows/docker-unified.yml | 14 +++++++------- docker/datahub-ingestion-base/build.gradle | 2 +- docker/datahub-ingestion/build.gradle | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/docker-unified.yml b/.github/workflows/docker-unified.yml index 5f944c8e28..a756b27a38 100644 --- a/.github/workflows/docker-unified.yml +++ b/.github/workflows/docker-unified.yml @@ -44,6 +44,7 @@ jobs: tag: ${{ steps.tag.outputs.tag }} slim_tag: ${{ steps.tag.outputs.slim_tag }} full_tag: ${{ steps.tag.outputs.full_tag }} + short_sha: ${{ steps.tag.outputs.short_sha }} # needed for auto-deploy unique_tag: ${{ steps.tag.outputs.unique_tag }} unique_slim_tag: ${{ steps.tag.outputs.unique_slim_tag }} unique_full_tag: ${{ steps.tag.outputs.unique_full_tag }} @@ -65,6 +66,8 @@ jobs: postgres_setup_change: ${{ steps.ci-optimize.outputs.postgres-setup-change == 'true' }} elasticsearch_setup_change: ${{ steps.ci-optimize.outputs.elasticsearch-setup-change == 'true' }} smoke_test_change: ${{ steps.ci-optimize.outputs.smoke-test-change == 'true' }} + integrations_service_change: "false" + datahub_executor_change: "false" steps: - name: Check out the repo uses: acryldata/sane-checkout-action@v3 @@ -864,7 +867,8 @@ jobs: context: . file: ./docker/datahub-ingestion/Dockerfile platforms: linux/amd64,linux/arm64/v8 - depot-project: ${{ vars.DEPOT_PROJECT_ID }} + # Workaround 2025-01-25 - Depot publishing errors + depot-project: ${{ (startsWith(github.ref, 'refs/tags/') || github.event_name == 'release') && '' || vars.DEPOT_PROJECT_ID }} - name: Compute Tag id: tag run: echo "tag=${{ needs.setup.outputs.ingestion_change == 'true' && needs.setup.outputs.unique_slim_tag || 'head-slim' }}" >> "$GITHUB_OUTPUT" @@ -963,7 +967,8 @@ jobs: context: . file: ./docker/datahub-ingestion/Dockerfile platforms: linux/amd64,linux/arm64/v8 - depot-project: ${{ vars.DEPOT_PROJECT_ID }} + # Workaround 2025-01-25 - Depot publishing errors + depot-project: ${{ (startsWith(github.ref, 'refs/tags/') || github.event_name == 'release') && '' || vars.DEPOT_PROJECT_ID }} - name: Compute Tag (Full) id: tag run: echo "tag=${{ needs.setup.outputs.ingestion_change == 'true' && needs.setup.outputs.unique_tag || 'head' }}" >> "$GITHUB_OUTPUT" @@ -1178,11 +1183,6 @@ jobs: docker pull '${{ env.DATAHUB_ELASTIC_SETUP_IMAGE }}:head' docker tag '${{ env.DATAHUB_ELASTIC_SETUP_IMAGE }}:head' '${{ env.DATAHUB_ELASTIC_SETUP_IMAGE }}:${{ needs.setup.outputs.unique_tag }}' fi - if [ '${{ needs.setup.outputs.integrations_service_change }}' == 'false' ]; then - echo 'datahub-integration-service head images' - docker pull '${{ env.DATAHUB_INTEGRATIONS_IMAGE }}:head' - docker tag '${{ env.DATAHUB_INTEGRATIONS_IMAGE }}:head' '${{ env.DATAHUB_INTEGRATIONS_IMAGE }}:${{ needs.setup.outputs.unique_tag }}' - fi - name: CI Slim Head Images run: | if [ '${{ needs.setup.outputs.ingestion_change }}' == 'false' ]; then diff --git a/docker/datahub-ingestion-base/build.gradle b/docker/datahub-ingestion-base/build.gradle index f19faa227c..b3ed6463b9 100644 --- a/docker/datahub-ingestion-base/build.gradle +++ b/docker/datahub-ingestion-base/build.gradle @@ -12,7 +12,7 @@ ext { docker_target = project.getProperties().getOrDefault("dockerTarget", "slim") docker_version = "${version}${docker_target == 'slim' ? '-slim' : ''}" - revision = 8 // increment to trigger rebuild + revision = 10 // increment to trigger rebuild } docker { diff --git a/docker/datahub-ingestion/build.gradle b/docker/datahub-ingestion/build.gradle index b236a53c28..b0b666f75e 100644 --- a/docker/datahub-ingestion/build.gradle +++ b/docker/datahub-ingestion/build.gradle @@ -12,7 +12,7 @@ ext { docker_target = project.getProperties().getOrDefault("dockerTarget", "slim") docker_version = "${version}${docker_target == 'slim' ? '-slim' : ''}" - revision = 9 // increment to trigger rebuild + revision = 10 // increment to trigger rebuild } dependencies {