yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-08-19 14:44:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(cli): fix unknown aspect bug in dataset upsert cli (#12946)

Browse Source
This commit is contained in:
Harshal Sheth 2025-03-22 08:30:44 -07:00 committed by GitHub
parent 1d6c15edd3
commit dd4aff2208
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
metadata-ingestion/src/datahub/api/entities/dataset/dataset.py
View File

@ -506,7 +506,7 @@ class Dataset(StrictModel):
# We don't check references for tags # We don't check references for tags
return list(set(references)) return list(set(references))
def generate_mcp( # noqa: C901 def generate_mcp(
self, self,
) -> Iterable[Union[MetadataChangeProposalClass, MetadataChangeProposalWrapper]]: ) -> Iterable[Union[MetadataChangeProposalClass, MetadataChangeProposalWrapper]]:
mcp = MetadataChangeProposalWrapper( mcp = MetadataChangeProposalWrapper(
@ -643,33 +643,6 @@ class Dataset(StrictModel):
) )
assert field_urn.startswith("urn:li:schemaField:") assert field_urn.startswith("urn:li:schemaField:")
if field.globalTags:
mcp = MetadataChangeProposalWrapper(
entityUrn=field_urn,
aspect=GlobalTagsClass(
tags=[
TagAssociationClass(tag=make_tag_urn(tag))
for tag in field.globalTags
]
),
)
yield mcp
if field.glossaryTerms:
mcp = MetadataChangeProposalWrapper(
entityUrn=field_urn,
aspect=GlossaryTermsClass(
terms=[
GlossaryTermAssociationClass(
urn=make_term_urn(term)
)
for term in field.glossaryTerms
],
auditStamp=self._mint_auditstamp("yaml"),
),
)
yield mcp
if field.structured_properties: if field.structured_properties:
urn_prefix = f"{StructuredPropertyUrn.URN_PREFIX}:{StructuredPropertyUrn.LI_DOMAIN}:{StructuredPropertyUrn.ENTITY_TYPE}" urn_prefix = f"{StructuredPropertyUrn.URN_PREFIX}:{StructuredPropertyUrn.LI_DOMAIN}:{StructuredPropertyUrn.ENTITY_TYPE}"
mcp = MetadataChangeProposalWrapper( mcp = MetadataChangeProposalWrapper(