From dd95d674f4a2e2d0a2d5a989ddbd033e7cf53a0c Mon Sep 17 00:00:00 2001
From: Seyi Adebajo <sadebajo@linkedin.com>
Date: Tue, 25 Sep 2018 15:43:56 -0700
Subject: [PATCH] filters out suggested annotations for compliance policies
 that have recently been saved

---
 .../app/constants/dataset-compliance.ts       | 21 +++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)

diff --git a/wherehows-web/app/constants/dataset-compliance.ts b/wherehows-web/app/constants/dataset-compliance.ts
index fea47785f9..e23122eacd 100644
--- a/wherehows-web/app/constants/dataset-compliance.ts
+++ b/wherehows-web/app/constants/dataset-compliance.ts
@@ -1,4 +1,5 @@
 import { setProperties } from '@ember/object';
+import moment from 'moment';
 import { IdLogicalType, PurgePolicy } from 'wherehows-web/constants/index';
 import {
   IComplianceEntity,
@@ -190,6 +191,20 @@ const suggestedIdentifierTypesInList = (suggestion: ISuggestedFieldTypeValues |
 ): Array<IComplianceEntity['identifierType']> =>
   suggestion && suggestion.identifierType === identifierType ? [...list, identifierType] : list;
 
+/**
+ * The number of milliseconds determined as the recency window for annotation edits
+ * @type {number}
+ */
+const recencyWindow = moment.duration(1, 'hours').asMilliseconds();
+
+/**
+ * Determines if a policy modification time is within the recencyWindow
+ * @param {IComplianceInfo['modifiedTime']} policyModificationTime the time the compliance was annotated
+ * @returns {boolean}
+ */
+const isRecentlyUpdatedPolicy = (policyModificationTime: IComplianceInfo['modifiedTime']): boolean =>
+  policyModificationTime ? moment().diff(moment(policyModificationTime)) <= recencyWindow : false;
+
 /**
  * Checks if a tag (IComplianceChangeSet) instance should be reviewed for conflict with the suggested value
  * @param {SchemaFieldToSuggestedValue} suggestion
@@ -446,10 +461,12 @@ const fieldTagsRequiringReview = (
 const complianceEntityWithSuggestions = (suggestionMap: ISchemaFieldsToSuggested) => (
   entity: IComplianceEntityWithMetadata
 ): IComplianceChangeSet => {
-  const { identifierField } = entity;
+  const { identifierField, policyModificationTime } = entity;
   const suggestion = suggestionMap[identifierField];
+  // Check if the policy was recently saved and disregard suggested annotations
+  const isNotRecentlyUpdatedPolicy = not(isRecentlyUpdatedPolicy)(policyModificationTime);
 
-  return suggestion ? { ...entity, suggestion } : entity;
+  return suggestion && isNotRecentlyUpdatedPolicy ? { ...entity, suggestion } : entity;
 };
 
 /**