yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-09-04 23:00:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

filters out suggested annotations for compliance policies that have recently been saved

Browse Source
This commit is contained in:
Seyi Adebajo 2018-09-25 15:43:56 -07:00
parent f3245032d0
commit dd95d674f4
1 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
wherehows-web/app/constants/dataset-compliance.ts
View File

@ -1,4 +1,5 @@
import { setProperties } from '@ember/object'; import { setProperties } from '@ember/object';
import moment from 'moment';
import { IdLogicalType, PurgePolicy } from 'wherehows-web/constants/index'; import { IdLogicalType, PurgePolicy } from 'wherehows-web/constants/index';
import { import {
IComplianceEntity, IComplianceEntity,
@ -190,6 +191,20 @@ const suggestedIdentifierTypesInList = (suggestion: ISuggestedFieldTypeValues |
): Array<IComplianceEntity['identifierType']> => ): Array<IComplianceEntity['identifierType']> =>
suggestion && suggestion.identifierType === identifierType ? [...list, identifierType] : list; suggestion && suggestion.identifierType === identifierType ? [...list, identifierType] : list;
/**
* The number of milliseconds determined as the recency window for annotation edits
* @type {number}
*/
const recencyWindow = moment.duration(1, 'hours').asMilliseconds();
/**
* Determines if a policy modification time is within the recencyWindow
* @param {IComplianceInfo['modifiedTime']} policyModificationTime the time the compliance was annotated
* @returns {boolean}
*/
const isRecentlyUpdatedPolicy = (policyModificationTime: IComplianceInfo['modifiedTime']): boolean =>
policyModificationTime ? moment().diff(moment(policyModificationTime)) <= recencyWindow : false;
/** /**
* Checks if a tag (IComplianceChangeSet) instance should be reviewed for conflict with the suggested value * Checks if a tag (IComplianceChangeSet) instance should be reviewed for conflict with the suggested value
* @param {SchemaFieldToSuggestedValue} suggestion * @param {SchemaFieldToSuggestedValue} suggestion
@ -446,10 +461,12 @@ const fieldTagsRequiringReview = (
const complianceEntityWithSuggestions = (suggestionMap: ISchemaFieldsToSuggested) => ( const complianceEntityWithSuggestions = (suggestionMap: ISchemaFieldsToSuggested) => (
entity: IComplianceEntityWithMetadata entity: IComplianceEntityWithMetadata
): IComplianceChangeSet => { ): IComplianceChangeSet => {
const { identifierField } = entity; const { identifierField, policyModificationTime } = entity;
const suggestion = suggestionMap[identifierField]; const suggestion = suggestionMap[identifierField];
// Check if the policy was recently saved and disregard suggested annotations
const isNotRecentlyUpdatedPolicy = not(isRecentlyUpdatedPolicy)(policyModificationTime);
return suggestion ? { ...entity, suggestion } : entity; return suggestion && isNotRecentlyUpdatedPolicy ? { ...entity, suggestion } : entity;
}; };
/** /**