Merge pull request #1402 from cptran777/release-health-tab

Will show dataset health tab except for graphs...
This commit is contained in:
Charlie Tran 2018-09-20 12:56:55 -07:00 committed by GitHub
commit dec9417376
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 28 deletions

View File

@ -1,12 +1,12 @@
<h3>Metadata Health</h3> <h3>Metadata Health</h3>
{{#unless tableData.length}} {{#if shouldShowDatasetHealth}}
{{datasets/health/metrics-charts {{datasets/health/metrics-charts
isActiveTab=isActiveTab isActiveTab=isActiveTab
categoryData=renderedCategories categoryData=renderedCategories
severityData=renderedSeverity severityData=renderedSeverity
onCategorySelect=(action onFilterSelect "category") onCategorySelect=(action onFilterSelect "category")
onSeveritySelect=(action onFilterSelect "severity")}} onSeveritySelect=(action onFilterSelect "severity")}}
{{/unless}} {{/if}}
{{datasets/health/score-table {{datasets/health/score-table
tableData=tableData tableData=tableData
currentCategoryFilter=currentCategoryFilter currentCategoryFilter=currentCategoryFilter

View File

@ -56,28 +56,19 @@
</div> </div>
{{/datasets/containers/dataset-fabrics}} {{/datasets/containers/dataset-fabrics}}
{{#if shouldShowDatasetHealth}} {{datasets/containers/dataset-owner-list
{{datasets/containers/dataset-owner-list urn=encodedUrn
urn=encodedUrn avatarEntityProps=avatarEntityProps
avatarEntityProps=avatarEntityProps class="dataset-owner-list"}}
class="dataset-owner-list"}}
{{#link-to "datasets.dataset.health" encodedUrn}} {{#link-to "datasets.dataset.health" encodedUrn}}
{{datasets/containers/health-score-gauge urn=encodedUrn wikiLinks=wikiLinks}} {{datasets/containers/health-score-gauge urn=encodedUrn wikiLinks=wikiLinks}}
{{/link-to}} {{/link-to}}
{{/if}}
</div> </div>
</div> </div>
</div> </div>
{{#unless shouldShowDatasetHealth}}
{{datasets/containers/dataset-owner-list
urn=encodedUrn
avatarEntityProps=avatarEntityProps
}}
{{/unless}}
</div> </div>
</div> </div>
@ -120,11 +111,9 @@
{{/tablist.tab}} {{/tablist.tab}}
{{/if}} {{/if}}
{{#if shouldShowDatasetHealth}} {{#tablist.tab tabIds.Health on-select=(action "tabSelectionChanged")}}
{{#tablist.tab tabIds.Health on-select=(action "tabSelectionChanged")}} Health
Health {{/tablist.tab}}
{{/tablist.tab}}
{{/if}}
{{/tabs.tablist}} {{/tabs.tablist}}
</div> </div>
@ -179,10 +168,12 @@
{{/tabs.tabpanel}} {{/tabs.tabpanel}}
{{/if}} {{/if}}
{{#if shouldShowDatasetHealth}} {{#tabs.tabpanel tabIds.Health}}
{{#tabs.tabpanel tabIds.Health}} {{datasets/containers/dataset-health
{{datasets/containers/dataset-health urn=encodedUrn tabSelected=tabSelected}} urn=encodedUrn
{{/tabs.tabpanel}} tabSelected=tabSelected
{{/if}} shouldShowDatasetHealth=shouldShowDatasetHealth
}}
{{/tabs.tabpanel}}
</div> </div>
{{/ivy-tabs}} {{/ivy-tabs}}