yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-10-31 02:37:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(cli): add-sibling preserve existing siblings (#9907)

Browse Source
This commit is contained in:
Steven Ayers 2024-02-23 19:30:17 +00:00 committed by GitHub
parent 639dd146d7
commit def4b24bb7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
metadata-ingestion/src/datahub/cli/specific/dataset_cli.py
View File

@ -93,13 +93,21 @@ def add_sibling(urn: str, sibling_urns: Tuple[str]) -> None:
def _emit_sibling( def _emit_sibling(
graph: DataHubGraph, primary_urn: str, urn: str, all_urns: Set[str] graph: DataHubGraph, primary_urn: str, urn: str, all_urns: Set[str]
) -> None: ) -> None:
siblings = [] siblings = _get_existing_siblings(graph, urn)
for sibling_urn in all_urns: for sibling_urn in all_urns:
if sibling_urn != urn: if sibling_urn != urn:
siblings.append(sibling_urn) siblings.add(sibling_urn)
graph.emit( graph.emit(
MetadataChangeProposalWrapper( MetadataChangeProposalWrapper(
entityUrn=urn, entityUrn=urn,
aspect=Siblings(primary=primary_urn == urn, siblings=sorted(siblings)), aspect=Siblings(primary=primary_urn == urn, siblings=sorted(siblings)),
) )
) )
def _get_existing_siblings(graph: DataHubGraph, urn: str) -> Set[str]:
existing = graph.get_aspect(urn, Siblings)
if existing:
return set(existing.siblings)
else:
return set()