From e35daf9ce4dd0ffd431e4e438c5334df5a15d433 Mon Sep 17 00:00:00 2001
From: Andrew Sikowitz <andrew.sikowitz@acryl.io>
Date: Wed, 16 Jul 2025 11:56:25 -0700
Subject: [PATCH] feat(logical): Add feature flag and models (#14097)

---
 .../resolvers/config/AppConfigResolver.java   |  1 +
 .../src/main/resources/app.graphql            |  5 +++
 datahub-web-react/src/appConfigContext.tsx    |  1 +
 datahub-web-react/src/graphql/app.graphql     |  1 +
 .../com/linkedin/logical/LogicalParent.pdl    | 31 +++++++++++++++++++
 .../src/main/resources/entity-registry.yml    |  2 ++
 .../graphql/featureflags/FeatureFlags.java    |  1 +
 .../src/main/resources/application.yaml       |  1 +
 8 files changed, 43 insertions(+)
 create mode 100644 metadata-models/src/main/pegasus/com/linkedin/logical/LogicalParent.pdl

diff --git a/datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/config/AppConfigResolver.java b/datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/config/AppConfigResolver.java
index 8508dcd193..7833a2fd74 100644
--- a/datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/config/AppConfigResolver.java
+++ b/datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/config/AppConfigResolver.java
@@ -283,6 +283,7 @@ public class AppConfigResolver implements DataFetcher<CompletableFuture<AppConfi
             .setShowHomePageRedesign(_featureFlags.isShowHomePageRedesign())
             .setShowProductUpdates(_featureFlags.isShowProductUpdates())
             .setLineageGraphV3(_featureFlags.isLineageGraphV3())
+            .setLogicalModelsEnabled(_featureFlags.isLogicalModelsEnabled())
             .build();
 
     appConfig.setFeatureFlags(featureFlagsConfig);
diff --git a/datahub-graphql-core/src/main/resources/app.graphql b/datahub-graphql-core/src/main/resources/app.graphql
index a6a9a8cb74..ffc835ce01 100644
--- a/datahub-graphql-core/src/main/resources/app.graphql
+++ b/datahub-graphql-core/src/main/resources/app.graphql
@@ -757,6 +757,11 @@ type FeatureFlagsConfig {
   Enables the redesign of the lineage v2 graph
   """
   lineageGraphV3: Boolean!
+
+  """
+  Enables logical models feature
+  """
+  logicalModelsEnabled: Boolean!
 }
 
 """
diff --git a/datahub-web-react/src/appConfigContext.tsx b/datahub-web-react/src/appConfigContext.tsx
index d7081bef8c..91fdf0ad1f 100644
--- a/datahub-web-react/src/appConfigContext.tsx
+++ b/datahub-web-react/src/appConfigContext.tsx
@@ -83,6 +83,7 @@ export const DEFAULT_APP_CONFIG = {
         showHomePageRedesign: false,
         showProductUpdates: false,
         lineageGraphV3: false,
+        logicalModelsEnabled: false,
     },
     chromeExtensionConfig: {
         enabled: false,
diff --git a/datahub-web-react/src/graphql/app.graphql b/datahub-web-react/src/graphql/app.graphql
index 427dbc367b..2a6c6c70e7 100644
--- a/datahub-web-react/src/graphql/app.graphql
+++ b/datahub-web-react/src/graphql/app.graphql
@@ -105,6 +105,7 @@ query appConfig {
             showHomePageRedesign
             showProductUpdates
             lineageGraphV3
+            logicalModelsEnabled
         }
         chromeExtensionConfig {
             enabled
diff --git a/metadata-models/src/main/pegasus/com/linkedin/logical/LogicalParent.pdl b/metadata-models/src/main/pegasus/com/linkedin/logical/LogicalParent.pdl
new file mode 100644
index 0000000000..7a56295cad
--- /dev/null
+++ b/metadata-models/src/main/pegasus/com/linkedin/logical/LogicalParent.pdl
@@ -0,0 +1,31 @@
+namespace com.linkedin.logical
+
+import com.linkedin.common.Edge
+
+@Aspect = {
+  "name": "logicalParent"
+}
+record LogicalParent {
+  @Relationship = {
+    "/destinationUrn": {
+      "name": "PhysicalInstanceOf",
+      "entityTypes": [ "dataset", "schemaField" ],
+      "createdOn": "parent/created/time",
+      "createdActor": "parent/created/actor",
+      "updatedOn": "parent/lastModified/time",
+      "updatedActor": "parent/lastModified/actor",
+      "properties": "parent/properties"
+    }
+  }
+  @Searchable = {
+    "/destinationUrn": {
+      "fieldName": "logicalParent",
+      "fieldType": "URN",
+      "queryByDefault": false,
+      "addToFilters": true,
+      "hasValuesFieldName": "hasLogicalParent",
+      "filterNameOverride": "Physical Instance Of"
+    }
+  }
+  parent: Edge
+}
diff --git a/metadata-models/src/main/resources/entity-registry.yml b/metadata-models/src/main/resources/entity-registry.yml
index 28a2b1ef84..d025b59a78 100644
--- a/metadata-models/src/main/resources/entity-registry.yml
+++ b/metadata-models/src/main/resources/entity-registry.yml
@@ -49,6 +49,7 @@ entities:
       - partitionsSummary
       - versionProperties
       - icebergCatalogInfo
+      - logicalParent
   - name: dataHubPolicy
     doc: DataHub Policies represent access policies granted to users or groups on metadata operations like edit, view etc.
     category: internal
@@ -524,6 +525,7 @@ entities:
       - testResults
       - deprecation
       - subTypes
+      - logicalParent
   - name: globalSettings
     doc: Global settings for an the platform
     category: internal
diff --git a/metadata-service/configuration/src/main/java/com/linkedin/datahub/graphql/featureflags/FeatureFlags.java b/metadata-service/configuration/src/main/java/com/linkedin/datahub/graphql/featureflags/FeatureFlags.java
index 4f51aa779c..cda141d1d5 100644
--- a/metadata-service/configuration/src/main/java/com/linkedin/datahub/graphql/featureflags/FeatureFlags.java
+++ b/metadata-service/configuration/src/main/java/com/linkedin/datahub/graphql/featureflags/FeatureFlags.java
@@ -45,4 +45,5 @@ public class FeatureFlags {
   private boolean showHomePageRedesign = false;
   private boolean lineageGraphV3 = true;
   private boolean showProductUpdates = false;
+  private boolean logicalModelsEnabled = false;
 }
diff --git a/metadata-service/configuration/src/main/resources/application.yaml b/metadata-service/configuration/src/main/resources/application.yaml
index 904bc814bf..5c2d5c985e 100644
--- a/metadata-service/configuration/src/main/resources/application.yaml
+++ b/metadata-service/configuration/src/main/resources/application.yaml
@@ -641,6 +641,7 @@ featureFlags:
   showHomePageRedesign: ${SHOW_HOME_PAGE_REDESIGN:false} # If turned on, show the re-designed home page
   lineageGraphV3: ${LINEAGE_GRAPH_V3:false}  # Enables the redesign of the lineage v2 graph
   showProductUpdates: ${SHOW_PRODUCT_UPDATES:true} # Whether to show in-product update popover on new updates.
+  logicalModelsEnabled: ${LOGICAL_MODELS_ENABLED:false}  # Enables logical models feature
 
 entityChangeEvents:
   enabled: ${ENABLE_ENTITY_CHANGE_EVENTS_HOOK:true}