yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-08-16 05:02:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(java) Update DataProductMapper to always return a name (#8832)

Browse Source
This commit is contained in:
Chris Collins 2023-09-13 11:18:52 -04:00 committed by GitHub
parent 785ab7718d
commit e9b4727c8e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/dataproduct/mappers/DataProductMapper.java
View File

@ -50,7 +50,8 @@ public class DataProductMapper implements ModelMapper<EntityResponse, DataProduc
EnvelopedAspectMap aspectMap = entityResponse.getAspects();
MappingHelper<DataProduct> mappingHelper = new MappingHelper<>(aspectMap, result);
mappingHelper.mapToResult(DATA_PRODUCT_PROPERTIES_ASPECT_NAME, this::mapDataProductProperties);
mappingHelper.mapToResult(DATA_PRODUCT_PROPERTIES_ASPECT_NAME, (dataProduct, dataMap) ->
mapDataProductProperties(dataProduct, dataMap, entityUrn));
mappingHelper.mapToResult(GLOBAL_TAGS_ASPECT_NAME, (dataProduct, dataMap) ->
dataProduct.setTags(GlobalTagsMapper.map(new GlobalTags(dataMap), entityUrn)));
mappingHelper.mapToResult(GLOSSARY_TERMS_ASPECT_NAME, (dataProduct, dataMap) ->
@ -65,11 +66,12 @@ public class DataProductMapper implements ModelMapper<EntityResponse, DataProduc
return result;
}
private void mapDataProductProperties(@Nonnull DataProduct dataProduct, @Nonnull DataMap dataMap) {
private void mapDataProductProperties(@Nonnull DataProduct dataProduct, @Nonnull DataMap dataMap, @Nonnull Urn urn) {
DataProductProperties dataProductProperties = new DataProductProperties(dataMap);
com.linkedin.datahub.graphql.generated.DataProductProperties properties = new com.linkedin.datahub.graphql.generated.DataProductProperties();
properties.setName(dataProductProperties.getName());
final String name = dataProductProperties.hasName() ? dataProductProperties.getName() : urn.getId();
properties.setName(name);
properties.setDescription(dataProductProperties.getDescription());
if (dataProductProperties.hasExternalUrl()) {
properties.setExternalUrl(dataProductProperties.getExternalUrl().toString());