From eb6b97c942a30b1d65a8e8d95ed1124f39c79804 Mon Sep 17 00:00:00 2001 From: "Yi (Alan) Wang" Date: Wed, 26 Sep 2018 14:18:32 -0700 Subject: [PATCH] Minor modification on Retention API, make it Nonnull (#1416) --- .../main/java/wherehows/dao/table/DatasetComplianceDao.java | 2 +- wherehows-frontend/app/controllers/api/v2/Dataset.java | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/wherehows-dao/src/main/java/wherehows/dao/table/DatasetComplianceDao.java b/wherehows-dao/src/main/java/wherehows/dao/table/DatasetComplianceDao.java index 002efedfd7..0ecdfff1a1 100644 --- a/wherehows-dao/src/main/java/wherehows/dao/table/DatasetComplianceDao.java +++ b/wherehows-dao/src/main/java/wherehows/dao/table/DatasetComplianceDao.java @@ -175,7 +175,7 @@ public class DatasetComplianceDao extends BaseDao { throw new UnsupportedOperationException("Not implemented yet"); } - @Nullable + @Nonnull public DatasetRetention getDatasetRetention(@Nonnull String datasetUrn) throws Exception { throw new UnsupportedOperationException("Not implemented yet"); } diff --git a/wherehows-frontend/app/controllers/api/v2/Dataset.java b/wherehows-frontend/app/controllers/api/v2/Dataset.java index a58320b09d..2c45ddf3fa 100644 --- a/wherehows-frontend/app/controllers/api/v2/Dataset.java +++ b/wherehows-frontend/app/controllers/api/v2/Dataset.java @@ -435,9 +435,6 @@ public class Dataset extends Controller { return Promise.promise(() -> internalServerError(errorResponse(e))); } - if (record == null) { - return Promise.promise(() -> notFound(_EMPTY_RESPONSE)); - } return Promise.promise(() -> ok(Json.newObject().set("retentionPolicy", Json.toJson(record)))); }