yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-08-26 10:06:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Made deprecation note nonnull (#982)

Browse Source
This commit is contained in:
Yi (Alan) Wang 2018-02-21 15:51:20 -08:00 committed by GitHub
parent e3672d8837
commit ed8ba02bed
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
wherehows-dao/src/main/java/wherehows/dao/table/DictDatasetDao.java
View File

@ -193,7 +193,7 @@ public class DictDatasetDao extends BaseDao {
} }
public void setDatasetDeprecation(@Nonnull String datasetUrn, boolean isDeprecated, public void setDatasetDeprecation(@Nonnull String datasetUrn, boolean isDeprecated,
@Nullable String deprecationNote, @Nonnull String user) throws Exception { @Nonnull String deprecationNote, @Nonnull String user) throws Exception {
throw new UnsupportedOperationException("Not implemented yet"); throw new UnsupportedOperationException("Not implemented yet");
} }

2
wherehows-frontend/app/controllers/api/v2/Dataset.java
View File

@ -152,7 +152,7 @@ public class Dataset extends Controller {
boolean deprecated = record.get("deprecated").asBoolean(); boolean deprecated = record.get("deprecated").asBoolean();
String deprecationNote = record.hasNonNull("deprecationNote") ? record.get("deprecationNote").asText() : null; String deprecationNote = record.hasNonNull("deprecationNote") ? record.get("deprecationNote").asText() : "";
DICT_DATASET_DAO.setDatasetDeprecation(datasetUrn, deprecated, deprecationNote, username); DICT_DATASET_DAO.setDatasetDeprecation(datasetUrn, deprecated, deprecationNote, username);
} catch (Exception e) { } catch (Exception e) {