yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-09-25 17:15:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs(ingest/looker): mark platform instance as a supported capability (#9347)

Browse Source
This commit is contained in:
Harshal Sheth 2023-11-30 03:51:44 -05:00 committed by GitHub
parent c3499f8661
commit efaf21d571
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
metadata-ingestion/src/datahub/ingestion/source/looker/looker_config.py
View File

@ -9,7 +9,10 @@ from typing_extensions import ClassVar
from datahub.configuration import ConfigModel from datahub.configuration import ConfigModel
from datahub.configuration.common import AllowDenyPattern, ConfigurationError from datahub.configuration.common import AllowDenyPattern, ConfigurationError
from datahub.configuration.source_common import DatasetSourceConfigMixin, EnvConfigMixin from datahub.configuration.source_common import (
EnvConfigMixin,
PlatformInstanceConfigMixin,
)
from datahub.configuration.validate_field_removal import pydantic_removed_field from datahub.configuration.validate_field_removal import pydantic_removed_field
from datahub.ingestion.source.looker.looker_lib_wrapper import LookerAPIConfig from datahub.ingestion.source.looker.looker_lib_wrapper import LookerAPIConfig
from datahub.ingestion.source.state.stale_entity_removal_handler import ( from datahub.ingestion.source.state.stale_entity_removal_handler import (
@ -98,7 +101,7 @@ class LookerViewNamingPattern(NamingPattern):
] ]
class LookerCommonConfig(DatasetSourceConfigMixin): class LookerCommonConfig(EnvConfigMixin, PlatformInstanceConfigMixin):
explore_naming_pattern: LookerNamingPattern = pydantic.Field( explore_naming_pattern: LookerNamingPattern = pydantic.Field(
description=f"Pattern for providing dataset names to explores. {LookerNamingPattern.allowed_docstring()}", description=f"Pattern for providing dataset names to explores. {LookerNamingPattern.allowed_docstring()}",
default=LookerNamingPattern(pattern="{model}.explore.{name}"), default=LookerNamingPattern(pattern="{model}.explore.{name}"),

2
metadata-ingestion/src/datahub/ingestion/source/looker/looker_source.py
View File

@ -99,7 +99,7 @@ logger = logging.getLogger(__name__)
@support_status(SupportStatus.CERTIFIED) @support_status(SupportStatus.CERTIFIED)
@config_class(LookerDashboardSourceConfig) @config_class(LookerDashboardSourceConfig)
@capability(SourceCapability.DESCRIPTIONS, "Enabled by default") @capability(SourceCapability.DESCRIPTIONS, "Enabled by default")
@capability(SourceCapability.PLATFORM_INSTANCE, "Not supported", supported=False) @capability(SourceCapability.PLATFORM_INSTANCE, "Use the `platform_instance` field")
@capability( @capability(
SourceCapability.OWNERSHIP, "Enabled by default, configured using `extract_owners`" SourceCapability.OWNERSHIP, "Enabled by default, configured using `extract_owners`"
) )

2
metadata-ingestion/src/datahub/ingestion/source/looker/lookml_source.py
View File

@ -1455,7 +1455,7 @@ class LookerManifest:
@support_status(SupportStatus.CERTIFIED) @support_status(SupportStatus.CERTIFIED)
@capability( @capability(
SourceCapability.PLATFORM_INSTANCE, SourceCapability.PLATFORM_INSTANCE,
"Supported using the `connection_to_platform_map`", "Use the `platform_instance` and `connection_to_platform_map` fields",
) )
@capability(SourceCapability.LINEAGE_COARSE, "Supported by default") @capability(SourceCapability.LINEAGE_COARSE, "Supported by default")
@capability( @capability(