yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-10-02 12:37:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(analytics): Add page number to SearchResultClickEvent analytics event (#11151)

Browse Source
This commit is contained in:
Filipe Caetano - OVO 2024-08-20 14:11:38 +01:00 committed by GitHub
parent 8f7642b910
commit f15a7feda3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
datahub-web-react/src/app/analytics/event.ts
View File

@ -191,6 +191,7 @@ export interface SearchResultClickEvent extends BaseEvent {
entityTypeFilter?: EntityType; entityTypeFilter?: EntityType;
index: number; index: number;
total: number; total: number;
pageNumber: number;
} }
export interface SearchFiltersClearAllEvent extends BaseEvent { export interface SearchFiltersClearAllEvent extends BaseEvent {

3
datahub-web-react/src/app/search/SearchResultList.tsx
View File

@ -62,6 +62,7 @@ type Props = {
selectedEntities: EntityAndType[]; selectedEntities: EntityAndType[];
setSelectedEntities: (entities: EntityAndType[]) => any; setSelectedEntities: (entities: EntityAndType[]) => any;
suggestions: SearchSuggestion[]; suggestions: SearchSuggestion[];
pageNumber: number;
}; };
export const SearchResultList = ({ export const SearchResultList = ({
@ -73,6 +74,7 @@ export const SearchResultList = ({
selectedEntities, selectedEntities,
setSelectedEntities, setSelectedEntities,
suggestions, suggestions,
pageNumber,
}: Props) => { }: Props) => {
const entityRegistry = useEntityRegistry(); const entityRegistry = useEntityRegistry();
const selectedEntityUrns = selectedEntities.map((entity) => entity.urn); const selectedEntityUrns = selectedEntities.map((entity) => entity.urn);
@ -86,6 +88,7 @@ export const SearchResultList = ({
entityType: result.entity.type, entityType: result.entity.type,
index, index,
total: totalResultCount, total: totalResultCount,
pageNumber,
}); });
}; };

1
datahub-web-react/src/app/search/SearchResults.tsx
View File

@ -264,6 +264,7 @@ export const SearchResults = ({
selectedEntities={selectedEntities} selectedEntities={selectedEntities}
setSelectedEntities={setSelectedEntities} setSelectedEntities={setSelectedEntities}
suggestions={suggestions} suggestions={suggestions}
pageNumber={page}
/> />
{totalResults > 0 && ( {totalResults > 0 && (
<PaginationControlContainer id="search-pagination"> <PaginationControlContainer id="search-pagination">

2
docs/developers.md
View File

@ -46,7 +46,7 @@ Use [gradle wrapper](https://docs.gradle.org/current/userguide/gradle_wrapper.ht
./gradlew build ./gradlew build
``` ```
Note that the above will also run run tests and a number of validations which makes the process considerably slower. Note that the above will also run tests and a number of validations which makes the process considerably slower.
We suggest partially compiling DataHub according to your needs: We suggest partially compiling DataHub according to your needs: