yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-09-17 05:03:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ingest): allow ingestion of glossary terms without nodes (#3253)

Browse Source
This commit is contained in:
Remi 2021-09-17 00:11:25 -06:00 committed by GitHub
parent 9db7a34cfa
commit f307521331
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 23 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
metadata-ingestion/src/datahub/ingestion/source/metadata/business_glossary.py
View File

@ -62,7 +62,8 @@ class BusinessGlossarySourceConfig(ConfigModel):
class BusinessGlossaryConfig(DefaultConfig): class BusinessGlossaryConfig(DefaultConfig):
version: str version: str
nodes: List[GlossaryNodeConfig] nodes: Optional[List[GlossaryNodeConfig]]
terms: Optional[List[GlossaryTermConfig]]
@validator("version") @validator("version")
def version_must_be_1(cls, v): def version_must_be_1(cls, v):
@ -106,6 +107,7 @@ def get_mces(
path: List[str] = [] path: List[str] = []
root_owners = get_owners(glossary.owners) root_owners = get_owners(glossary.owners)
if glossary.nodes:
for node in glossary.nodes: for node in glossary.nodes:
events += get_mces_from_node( events += get_mces_from_node(
node, node,
@ -114,6 +116,17 @@ def get_mces(
parentOwners=root_owners, parentOwners=root_owners,
defaults=glossary, defaults=glossary,
) )
if glossary.terms:
for term in glossary.terms:
events += get_mces_from_term(
term,
path + [term.name],
parentNode=None,
parentOwnership=root_owners,
defaults=glossary,
)
return events return events
@ -171,7 +184,7 @@ def get_mces_from_node(
def get_mces_from_term( def get_mces_from_term(
glossaryTerm: GlossaryTermConfig, glossaryTerm: GlossaryTermConfig,
path: List[str], path: List[str],
parentNode: str, parentNode: Optional[str],
parentOwnership: models.OwnershipClass, parentOwnership: models.OwnershipClass,
defaults: DefaultConfig, defaults: DefaultConfig,
) -> List[models.MetadataChangeEventClass]: ) -> List[models.MetadataChangeEventClass]: