yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-08-19 06:38:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(cypress) Catch resizeObserverLoop globally and fix setThemeV2 (#13288)

Browse Source
This commit is contained in:
Chris Collins 2025-04-22 14:12:42 -04:00 committed by GitHub
parent 169c982b4d
commit fa531d70c8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
smoke-test/tests/cypress/cypress/e2e/auto_completeV2/v2_auto_complete.js
View File

@ -4,7 +4,6 @@ describe("auto-complete", () => {
cy.skipIntroducePage(); cy.skipIntroducePage();
cy.hideOnboardingTour(); cy.hideOnboardingTour();
cy.login(); cy.login();
cy.ignoreResizeObserverLoop();
// look for a dataset // look for a dataset
cy.visit("/"); cy.visit("/");
cy.wait(2000); cy.wait(2000);

1
smoke-test/tests/cypress/cypress/e2e/domains/nested_domains.js
View File

@ -90,7 +90,6 @@ describe("Verify nested domains test functionalities", () => {
cy.setIsThemeV2Enabled(false); cy.setIsThemeV2Enabled(false);
cy.loginWithCredentials(); cy.loginWithCredentials();
cy.goToDomainList(); cy.goToDomainList();
cy.ignoreResizeObserverLoop();
}); });
it("Verify Create a new domain", () => { it("Verify Create a new domain", () => {

4
smoke-test/tests/cypress/cypress/e2e/manage_tags/manage_tags.js
View File

@ -1,8 +1,4 @@
describe("manage tags", () => { describe("manage tags", () => {
beforeEach(() => {
cy.ignoreResizeObserverLoop();
});
it("Manage Tags Page - Verify search bar placeholder", () => { it("Manage Tags Page - Verify search bar placeholder", () => {
cy.login(); cy.login();
cy.visit("/tags"); cy.visit("/tags");

1
smoke-test/tests/cypress/cypress/e2e/mutations/managing_secrets.js
View File

@ -9,7 +9,6 @@ const ingestion_source_name = `ingestion source ${number}`;
describe("managing secrets for ingestion creation", () => { describe("managing secrets for ingestion creation", () => {
it("create a secret, create ingestion source using a secret, remove a secret", () => { it("create a secret, create ingestion source using a secret, remove a secret", () => {
// Navigate to the manage ingestion page → secrets // Navigate to the manage ingestion page → secrets
cy.ignoreResizeObserverLoop();
cy.loginWithCredentials(); cy.loginWithCredentials();
cy.goToIngestionPage(); cy.goToIngestionPage();
cy.clickOptionWithText("Secrets"); cy.clickOptionWithText("Secrets");

19
smoke-test/tests/cypress/cypress/support/commands.js
View File

@ -531,17 +531,22 @@ Cypress.Commands.add("setIsThemeV2Enabled", (isEnabled) => {
res.body.data.appConfig.featureFlags.themeV2Default = isEnabled; res.body.data.appConfig.featureFlags.themeV2Default = isEnabled;
res.body.data.appConfig.featureFlags.showNavBarRedesign = isEnabled; res.body.data.appConfig.featureFlags.showNavBarRedesign = isEnabled;
}); });
} else if (hasOperationName(req, "getMe")) {
req.alias = "gqlgetMeQuery";
req.on("response", (res) => {
res.body.data.me.corpUser.settings.appearance.showThemeV2 = isEnabled;
});
} }
}); });
}); });
Cypress.Commands.add("ignoreResizeObserverLoop", () => { Cypress.on("uncaught:exception", (err) => {
const resizeObserverLoopErrRe = "ResizeObserver loop limit exceeded"; const resizeObserverLoopErrMessage = "ResizeObserver loop limit exceeded";
cy.on("uncaught:exception", (err) => {
if (err.message.includes(resizeObserverLoopErrRe)) { /* returning false here prevents Cypress from failing the test */
return false; if (err.message.includes(resizeObserverLoopErrMessage)) {
} return false;
}); }
}); });
// //