yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-09-01 05:13:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup event listener

Browse Source
This commit is contained in:
cptran777 2018-09-07 11:27:54 -07:00
parent 5c1785ba70
commit fcb3c1dd6b
1 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
wherehows-web/app/components/hotkeys/global-hotkeys.ts
View File

@ -1,5 +1,5 @@
import Component from '@ember/component';
import { get, set } from '@ember/object';
import { get } from '@ember/object';
import { service } from '@ember-decorators/service';
import ComputedProperty from '@ember/object/computed';
import HotKeys from 'wherehows-web/services/hot-keys';
@ -39,11 +39,6 @@ export default class GlobalHotkeys extends Component {
@service
hotKeys: ComputedProperty<HotKeys>;
/**
* The event listener function created for the body
*/
bodyEventListener: (e: KeyboardEvent) => void;
/**
* Returns true if target exists, is not an input, and is not an editable div
* @param {HTMLElement} target - target element
@ -61,19 +56,21 @@ export default class GlobalHotkeys extends Component {
* Method for handling the global keyup.
* @param {KeyboardEvent} e - KeyboardEvent triggered by user input
*/
onKeyUp(e: KeyboardEvent) {
// Note: Important to define this as an arrow function in order to maintain this context when
// attaching to event listener below
onKeyUp = (e: KeyboardEvent) => {
const target = <HTMLElement>e.target;
if (this.isEligibleTarget(target)) {
get(this, 'hotKeys').applyKeyMapping(e.keyCode);
}
}
};
didInsertElement() {
const body = document.querySelector('.ember-application');
if (body) {
body.addEventListener('keyup', set(this, 'bodyEventListener', this.onKeyUp.bind(this)));
body.addEventListener('keyup', this.onKeyUp);
}
}
@ -81,7 +78,7 @@ export default class GlobalHotkeys extends Component {
const body = document.querySelector('.ember-application');
if (body) {
body.removeEventListener('keyup', this.bodyEventListener);
body.removeEventListener('keyup', this.onKeyUp);
}
}
}