yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-12-30 03:18:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(ece): support custom ownership type urns in ECE generation (#10999)

Browse Source
This commit is contained in:
Harshal Sheth 2024-07-26 14:02:25 -07:00 committed by GitHub
parent bc75f7a1b1
commit fdbcb684ac
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 45 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
metadata-io/src/main/java/com/linkedin/metadata/timeline/data/entity/OwnerChangeEvent.java
View File

@ -27,17 +27,29 @@ public class OwnerChangeEvent extends ChangeEvent {
SemanticChangeType semVerChange,
String description,
Urn ownerUrn,
OwnershipType ownerType) {
OwnershipType ownerType,
Urn ownerTypeUrn) {
super(
entityUrn,
category,
operation,
modifier,
ImmutableMap.of(
"ownerUrn", ownerUrn.toString(),
"ownerType", ownerType.toString()),
buildParameters(ownerUrn, ownerType, ownerTypeUrn),
auditStamp,
semVerChange,
description);
}
private static ImmutableMap<String, Object> buildParameters(
Urn ownerUrn, OwnershipType ownerType, Urn ownerTypeUrn) {
ImmutableMap.Builder<String, Object> builder =
new ImmutableMap.Builder<String, Object>()
.put("ownerUrn", ownerUrn.toString())
.put("ownerType", ownerType.toString());
if (ownerTypeUrn != null) {
builder.put("ownerTypeUrn", ownerTypeUrn.toString());
}
return builder.build();
}
}

5
metadata-io/src/main/java/com/linkedin/metadata/timeline/eventgenerator/OwnershipChangeEventGenerator.java
View File

@ -62,6 +62,7 @@ public class OwnershipChangeEventGenerator extends EntityChangeEventGenerator<Ow
entityUrn))
.ownerUrn(targetOwner.getOwner())
.ownerType(targetOwner.getType())
.ownerTypeUrn(targetOwner.getTypeUrn())
.auditStamp(auditStamp)
.build());
}
@ -84,6 +85,7 @@ public class OwnershipChangeEventGenerator extends EntityChangeEventGenerator<Ow
entityUrn))
.ownerUrn(baseOwner.getOwner())
.ownerType(baseOwner.getType())
.ownerTypeUrn(baseOwner.getTypeUrn())
.auditStamp(auditStamp)
.build());
++baseOwnerIdx;
@ -104,6 +106,7 @@ public class OwnershipChangeEventGenerator extends EntityChangeEventGenerator<Ow
entityUrn))
.ownerUrn(targetOwner.getOwner())
.ownerType(targetOwner.getType())
.ownerTypeUrn(targetOwner.getTypeUrn())
.auditStamp(auditStamp)
.build());
++targetOwnerIdx;
@ -128,6 +131,7 @@ public class OwnershipChangeEventGenerator extends EntityChangeEventGenerator<Ow
entityUrn))
.ownerUrn(baseOwner.getOwner())
.ownerType(baseOwner.getType())
.ownerTypeUrn(baseOwner.getTypeUrn())
.auditStamp(auditStamp)
.build());
++baseOwnerIdx;
@ -150,6 +154,7 @@ public class OwnershipChangeEventGenerator extends EntityChangeEventGenerator<Ow
entityUrn))
.ownerUrn(targetOwner.getOwner())
.ownerType(targetOwner.getType())
.ownerTypeUrn(targetOwner.getTypeUrn())
.auditStamp(auditStamp)
.build());
++targetOwnerIdx;

26
metadata-jobs/mae-consumer/src/test/java/com/linkedin/metadata/kafka/hook/event/EntityChangeEventGeneratorHookTest.java
View File

@ -309,11 +309,16 @@ public class EntityChangeEventGeneratorHookTest {
final Ownership newOwners = new Ownership();
final Urn ownerUrn1 = Urn.createFromString("urn:li:corpuser:test1");
final Urn ownerUrn2 = Urn.createFromString("urn:li:corpuser:test2");
final Urn ownerUrn3 = Urn.createFromString("urn:li:corpuser:test3");
newOwners.setOwners(
new OwnerArray(
ImmutableList.of(
new Owner().setOwner(ownerUrn1).setType(OwnershipType.TECHNICAL_OWNER),
new Owner().setOwner(ownerUrn2).setType(OwnershipType.BUSINESS_OWNER))));
new Owner().setOwner(ownerUrn2).setType(OwnershipType.BUSINESS_OWNER),
new Owner()
.setOwner(ownerUrn3)
.setType(OwnershipType.CUSTOM)
.setTypeUrn(Urn.createFromString("urn:li:ownershipType:my_custom_type")))));
final Ownership prevOwners = new Ownership();
prevOwners.setOwners(new OwnerArray());
event.setAspect(GenericRecordUtils.serializeAspect(newOwners));
@ -354,7 +359,24 @@ public class EntityChangeEventGeneratorHookTest {
"ownerType",
OwnershipType.BUSINESS_OWNER.toString()),
actorUrn);
verifyProducePlatformEvent(_mockClient, platformEvent2, true);
verifyProducePlatformEvent(_mockClient, platformEvent2, false);
PlatformEvent platformEvent3 =
createChangeEvent(
DATASET_ENTITY_NAME,
Urn.createFromString(TEST_DATASET_URN),
ChangeCategory.OWNER,
ChangeOperation.ADD,
ownerUrn3.toString(),
ImmutableMap.of(
"ownerUrn",
ownerUrn3.toString(),
"ownerType",
OwnershipType.CUSTOM.toString(),
"ownerTypeUrn",
"urn:li:ownershipType:my_custom_type"),
actorUrn);
verifyProducePlatformEvent(_mockClient, platformEvent3, true);
}
@Test