yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-12-16 12:38:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(cli): don't use /api in gms url (#12083)

Browse Source
This commit is contained in:
Aseem Bansal 2024-12-11 16:11:08 +05:30 committed by GitHub
parent 355a7e69aa
commit ff7ac48021
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
metadata-ingestion/src/datahub/cli/cli_utils.py
View File

@ -327,6 +327,8 @@ def _ensure_valid_gms_url_acryl_cloud(url: str) -> str:
url = f"{url}/gms" url = f"{url}/gms"
elif url.endswith("acryl.io/"): elif url.endswith("acryl.io/"):
url = f"{url}gms" url = f"{url}gms"
if url.endswith("acryl.io/api/gms"):
url = url.replace("acryl.io/api/gms", "acryl.io/gms")
return url return url

4
metadata-ingestion/tests/unit/cli/test_cli_utils.py
View File

@ -66,6 +66,10 @@ def test_fixup_gms_url():
assert cli_utils.fixup_gms_url("http://localhost:8080") == "http://localhost:8080" assert cli_utils.fixup_gms_url("http://localhost:8080") == "http://localhost:8080"
assert cli_utils.fixup_gms_url("http://localhost:8080/") == "http://localhost:8080" assert cli_utils.fixup_gms_url("http://localhost:8080/") == "http://localhost:8080"
assert cli_utils.fixup_gms_url("http://abc.acryl.io") == "https://abc.acryl.io/gms" assert cli_utils.fixup_gms_url("http://abc.acryl.io") == "https://abc.acryl.io/gms"
assert (
cli_utils.fixup_gms_url("http://abc.acryl.io/api/gms")
== "https://abc.acryl.io/gms"
)
def test_guess_frontend_url_from_gms_url(): def test_guess_frontend_url_from_gms_url():