yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2026-01-05 22:34:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ingest/mssql): Add MONEY and SMALLMONEY data types as Number (#9313)

Browse Source
This commit is contained in:
terratrue-daniel 2023-11-28 11:43:52 -08:00 committed by GitHub
parent ac7fa5624f
commit ff9876f5a2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 34 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
metadata-ingestion/src/datahub/ingestion/source/sql/mssql/source.py
View File

@ -48,6 +48,7 @@ from datahub.ingestion.source.sql.sql_config import (
)
from datahub.metadata.schema_classes import (
BooleanTypeClass,
NumberTypeClass,
StringTypeClass,
UnionTypeClass,
)
@ -55,6 +56,8 @@ from datahub.metadata.schema_classes import (
logger: logging.Logger = logging.getLogger(__name__)
register_custom_type(sqlalchemy.dialects.mssql.BIT, BooleanTypeClass)
register_custom_type(sqlalchemy.dialects.mssql.MONEY, NumberTypeClass)
register_custom_type(sqlalchemy.dialects.mssql.SMALLMONEY, NumberTypeClass)
register_custom_type(sqlalchemy.dialects.mssql.SQL_VARIANT, UnionTypeClass)
register_custom_type(sqlalchemy.dialects.mssql.UNIQUEIDENTIFIER, StringTypeClass)

34
metadata-ingestion/tests/integration/sql_server/golden_files/golden_mces_mssql_no_db_to_file.json
View File

@ -112,11 +112,11 @@
"aspect": {
"json": {
"customProperties": {
"job_id": "1f2f14ba-db84-4fa1-910e-7df71bede642",
"job_id": "3565ea3e-9a3a-4cb0-acd5-213d740479a0",
"job_name": "Weekly Demo Data Backup",
"description": "No description available.",
"date_created": "2023-10-27 10:11:55.540000",
"date_modified": "2023-10-27 10:11:55.667000",
"date_created": "2023-11-27 23:08:29.350000",
"date_modified": "2023-11-27 23:08:29.833000",
"step_id": "1",
"step_name": "Set database to read only",
"subsystem": "TSQL",
@ -1961,8 +1961,8 @@
"code": "CREATE PROCEDURE [Foo].[Proc.With.SpecialChar] @ID INT\nAS\n SELECT @ID AS ThatDB;\n",
"input parameters": "['@ID']",
"parameter @ID": "{'type': 'int'}",
"date_created": "2023-10-27 10:11:55.460000",
"date_modified": "2023-10-27 10:11:55.460000"
"date_created": "2023-11-27 23:08:29.077000",
"date_modified": "2023-11-27 23:08:29.077000"
},
"externalUrl": "",
"name": "demodata.Foo.Proc.With.SpecialChar",
@ -3575,6 +3575,18 @@
"nativeDataType": "NVARCHAR()",
"recursive": false,
"isPartOfKey": false
},
{
"fieldPath": "Price",
"nullable": true,
"type": {
"type": {
"com.linkedin.pegasus2avro.schema.NumberType": {}
}
},
"nativeDataType": "MONEY()",
"recursive": false,
"isPartOfKey": false
}
]
}
@ -3816,6 +3828,18 @@
"nativeDataType": "NVARCHAR()",
"recursive": false,
"isPartOfKey": false
},
{
"fieldPath": "Price",
"nullable": true,
"type": {
"type": {
"com.linkedin.pegasus2avro.schema.NumberType": {}
}
},
"nativeDataType": "SMALLMONEY()",
"recursive": false,
"isPartOfKey": false
}
]
}

4
metadata-ingestion/tests/integration/sql_server/setup/setup.sql
View File

@ -2,11 +2,11 @@ CREATE DATABASE NewData;
GO
USE NewData;
GO
CREATE TABLE ProductsNew (ID int, ProductName nvarchar(max));
CREATE TABLE ProductsNew (ID int, ProductName nvarchar(max), Price money);
GO
CREATE SCHEMA FooNew;
GO
CREATE TABLE FooNew.ItemsNew (ID int, ItemName nvarchar(max));
CREATE TABLE FooNew.ItemsNew (ID int, ItemName nvarchar(max), Price smallmoney);
GO
CREATE TABLE FooNew.PersonsNew (
ID int NOT NULL PRIMARY KEY,