The coupling was between the static path extractor API. This broken by making a new `UrnPathExtractor` interface, and adding an overload of `EbeanLocalDAO`'s constructor to accept one (no breaking constructor change). The old constructors default to an `EmptyPathExtractor`, which does nothing (which is a breaking behavioral change, see below).
BREAKING: `DatasetUrnPathExtractor` was deleted. No one should've been depending on this directly. However, downstreams that were relying on it being there at runtime (dataset GMS) need to copy `DatasetUrnPathExtractor` and create their `EbeanLocalDAO` with one. Note that this is a little dangerous becasue it is a runtime behavioral change only. Potential impact is that SCSI suddenly stops working as intended.
SYNC=metadata-models_101.0.0
- Add build files for new module.
- Correctly edit TestUtils since it isn't synced.
- Reference new test utils.
- Delete duplicate pdl files.
SYNC=metadata-models_100.0.1
Requested by a few people in OS. See https://github.com/linkedin/datahub/issues/1840.
Companies need full customization over the topic name. This new class should be easily customizable by using a spring factory.
TODO to finish the implmentation for v5. For right now v5 is LI only and unfinished. Getting this in for v4 so it is useful to other companies now.
TODO AFTER OPEN SOURCE PUSH - make configurable via spring
TODO AFTER SUBMIT - see where else we can use this (jobs, where else?)
* fix (docker): Fix install of Chrome in frontend Dockerimage
Retry installing Chrome after dependencies have been installed
* fix (docker): Install Chrome with apt-get
Install Chrome and dependencies at the same time, using apt-get
This seems helpful to reviewers (and probably also the author). Motivation is too high level to be able to properly review a design. We need a clear set of requirements to review the design against.
Start adding java ETL examples, starting with kafka etl.
We've had a few requests to start providing Java examples rather than Python due to type safety.
I've also started to add these to metadata-ingestion-examples to make it clearer these are *examples*. They can be used directly or as a basis for other things.
As we port to Java we'll move examples to contrib.
* Create RFC for ML Model
* Add ml model graph file
* add link to graph
* Add high level design for ML model
* ai->ml
* Rename 000-ml_models.md to README.md
* Add link to RFC PR
* Update README.md
* address some comments
* Delete ml_model_graph.png
* add ML Model graph
* Address reviewer comments
* Address more comments
* Update README.md
* Rename docs/rfc/active/000-ml_models/README.md to docs/rfc/active/1812-ml_models/README.md
* Delete high_level_design.png
* Delete ml_model_graph.png
* Add files via upload
Co-authored-by: Mars Lan <mars.th.lan@gmail.com>
- Add commonsLang to build file.
- Add emails field to CorpUserInfoDocument (either this should be synced or the index builder not synced in the future).
- Fix EbeanLocalDAOTest which used internal Urn API.
- Fix BaseSearchableEntityResource "backfill" override return types (and regenerate snapshots).
- EbeanlocalDAO's constructor changed; now requires URN class.
- Add restli resource module as dependency of :gms:api as it now contains a needed PDL model.
- Upgrade to checkstyle 8
- Copy javadoc checks from Google
- Disable missing class and method checks for now, too many warnings. I'll have to figure out how to suppress them instead.
- Fix other issues, which are mostly missing periods at the end of sentences and lack of paragraph tags.
Revert "Reverting the commit range: 8dfdb73ac6c73581ef56c0d81c21a2a92e8a1a02..194bd6f57f4a4d075d2ea1f442397d1139080f7a."
This reverts commit ab178ec1469fa72c0c339f0b842e7ff0850e7c74.
