3083 Commits

Author SHA1 Message Date
Seyi Adebajo
5a8837b3ea updates the suggestion column in compliance table to match interface design. renders more text per line in compliance field identifier column 2018-06-26 17:47:41 -07:00
Seyi Adebajo
90992fa9f8 fix pii tooltip rendering offscreen 2018-06-26 17:10:11 -07:00
Seyi Adebajo
97327abea4 fixes compliance dialog article/section height in firefox 2018-06-26 17:03:01 -07:00
Seyi Adebajo
0bc10758ec splits compliance field validation computed property by creating a separate dependent property without a check for suggestion mismatch but depends on the output from a full validation 2018-06-26 16:41:26 -07:00
Seyi Adebajo
4e2f586e9c
Merge pull request #1232 from theseyi/utils
adds util function for iteratee compose function. refactors dataset compliance function name editableTags
2018-06-26 11:54:00 -07:00
Seyi Adebajo
62c2bd5837
Merge pull request #1225 from theseyi/remove-ownership-flags
removes obsolete flags for ownership feature gate
2018-06-26 11:53:30 -07:00
Seyi Adebajo
7198b6471d moves noop to util helpers module 2018-06-25 23:42:28 -07:00
Seyi Adebajo
7ed763cb8c adds util function for iteratee componse function. refactors dataset compliance function name editableTags 2018-06-25 22:49:23 -07:00
Jyoti Wadhwani
9ec0459cbd api for field format docs 2018-06-25 10:29:20 -07:00
Mars Lan
27acfc1495
Rename "Add new" to "Add More" for clarity (#1230) 2018-06-22 16:48:12 -07:00
Seyi Adebajo
e3eade34de
Merge pull request #1229 from theseyi/styling-updates
minor styling updates to the compliance table styles
2018-06-22 15:07:48 -07:00
Seyi Adebajo
2def8b7fdb minor styling updates to the compliance table styles 2018-06-22 14:46:38 -07:00
Seyi Adebajo
5fffa5534c
Merge pull request #1228 from theseyi/reviewable-updates
reviewable updates
2018-06-22 14:19:38 -07:00
Yi (Alan) Wang
b3256082c2
Add sourceUrl transcient field to DatasetOwner (#1227) 2018-06-22 13:37:20 -07:00
Seyi Adebajo
caccb5ee78 filters readonly tags from initial step review validation. extracts suggestion conflict review check into contained function. creates function for initialStep review 2018-06-22 13:21:07 -07:00
Seyi Adebajo
b368a7706c includes readonly tags in tagNeedsReview check. reduces size threshold for notification-service modal to split-text 2018-06-21 18:52:27 -07:00
Seyi Adebajo
7186449552
Merge pull request #1222 from theseyi/suggestion-conflict-not-required
removes requirement that a suggestion conflict be resolved before use…
2018-06-21 14:55:02 -07:00
Jyoti Wadhwani
ce40bede1f
Merge pull request #1217 from jywadhwani/master
Point to the correct link of architecture design
2018-06-21 14:38:42 -07:00
Seyi Adebajo
b93e133dc2 removes obsolete flags for ownership feature gate
removes mid-tier config property for showOwnership feature flag

fix failing tests
2018-06-21 11:54:34 -07:00
Seyi Adebajo
392dc49a07
Merge pull request #1224 from linkedin/revert-1223-remove-ownership-flags
Revert "removes obsolete flags for ownership feature gate"
2018-06-21 11:45:26 -07:00
Seyi Adebajo
5f036581cc
Revert "removes obsolete flags for ownership feature gate" 2018-06-21 11:23:37 -07:00
Seyi Adebajo
5dd2846dc8 removes requirement that a suggestion conflict be resolved before user is able to proceed with compliance metadata update 2018-06-21 11:04:34 -07:00
Seyi Adebajo
3f316e47ed
Merge pull request #1223 from theseyi/remove-ownership-flags
removes obsolete flags for ownership feature gate
2018-06-21 11:01:46 -07:00
Seyi Adebajo
b3fc5842cc fix failing tests 2018-06-21 10:46:37 -07:00
Seyi Adebajo
cbc56bc614 removes mid-tier config property for showOwnership feature flag 2018-06-21 10:15:52 -07:00
Seyi Adebajo
9b3241787a removes obsolete flags for ownership feature gate 2018-06-21 10:15:51 -07:00
Seyi Adebajo
9c59d6f1e0
Merge pull request #1220 from theseyi/cosmetic-updates
updates misc visual styles for compliance tag dropdown. fixes z-index stacking issue that caused avatar metadata below to appear above field tag dropdown. fixes issue with containingPersonalData flag being null when user does not interact with toggle
2018-06-21 10:07:05 -07:00
Seyi Adebajo
0c59f3c00f
Merge pull request #1221 from theseyi/dataset-pii
updates styling on dataset pills
2018-06-21 10:06:48 -07:00
Seyi Adebajo
52fd1fa91f updates styling on dataset pills 2018-06-20 11:04:48 -07:00
Seyi Adebajo
3b5d3ef3aa updates misc visual styles for compliance tag dropdown. fixes z-index stacking issue that caused avatar metadata below to appear above field tag dropdown. fixes issue with containingPersonalData flag being null when user does not interact with toggle 2018-06-20 10:50:14 -07:00
Jyoti Wadhwani
4bb5a3fe8b change 2018-06-18 17:32:30 -07:00
Seyi Adebajo
04a17f851f
Merge pull request #1215 from theseyi/save-error-propagate
exposes api error on save in user notification
2018-06-18 15:50:33 -07:00
Seyi Adebajo
caed823ead reafactors validation for custom regex in data-set-compliance-tag 2018-06-18 15:50:07 -07:00
Yi (Alan) Wang
2c1e1fa240
MIE consumer to use platform specific listName API (#1214) 2018-06-18 15:41:11 -07:00
Seyi Adebajo
09c0cb3a50 exposes api error on save in user notification 2018-06-18 14:54:23 -07:00
Seyi Adebajo
d5dfb38a84
Merge pull request #1213 from theseyi/moar-propagate
throws more errors on failed schema validation
2018-06-18 14:19:14 -07:00
Seyi Adebajo
7409a5a00a adds more error propagation to schema validation 2018-06-18 13:35:39 -07:00
Yi (Alan) Wang
5e7a4c414e
MCE processor to update dataset deployment info (#1212) 2018-06-18 13:22:07 -07:00
Seyi Adebajo
dcba2c0bfc
Merge pull request #1211 from theseyi/updates-from-bb-session
updates to compliance dialog feature and bug fixes
2018-06-18 11:30:34 -07:00
Yi (Alan) Wang
a7fcffeecf
Update MetadataInventoryEvent schema (#1210) 2018-06-18 10:57:10 -07:00
Seyi Adebajo
46aec5b06c
Merge pull request #1207 from theseyi/contains-personal
adds pill indicating that the dataset contains personal data
2018-06-18 10:39:20 -07:00
Seyi Adebajo
5343abea3e
Merge pull request #1208 from theseyi/jit-latency
adds dialog indicating latency of 15 minutes when JIT request is succ…
2018-06-18 10:23:15 -07:00
Seyi Adebajo
55cd632f2d adds error messages display for JSON parse and some issues with matching compliance metadata schema 2018-06-17 03:51:10 -07:00
Seyi Adebajo
84ccd903d2 fixes issue with accepting suggested value when the tag already has a previous value 2018-06-17 02:55:31 -07:00
Seyi Adebajo
5df3deddcc changes has ownership header text to is purge key 2018-06-17 02:32:41 -07:00
Seyi Adebajo
7ba78c4e93 set dataset-compliance-field-tag dialog height to adjust viewport height dimensions 2018-06-17 01:46:57 -07:00
Seyi Adebajo
71172b5866 adds styling to field type headers to improve distinction 2018-06-17 01:38:21 -07:00
Seyi Adebajo
3e2b91a286 ensures dataset-compliance-field-tag dialog is auto closed once user marks field as done. renames field type headers for First Party IDs and Non First Party IDs 2018-06-17 01:30:58 -07:00
Seyi Adebajo
ff41815f63 fixes null pattern in validateRegExp util function 2018-06-17 01:16:10 -07:00
Seyi Adebajo
f9253623df adds check for reviewable attributes on local tag in dataset-compliance-field-tag validation step. adds valuePattern for custom logical type in tagNeedsReview function. moves regex checker to regexp module 2018-06-17 00:52:06 -07:00