import json import logging import os import pytest from boto3.session import Session from moto import mock_s3 from pydantic import ValidationError from datahub.ingestion.run.pipeline import Pipeline, PipelineContext from datahub.ingestion.source.s3.source import S3Source from tests.test_helpers import mce_helpers FROZEN_TIME = "2020-04-14 07:00:00" @pytest.fixture(scope="module", autouse=True) def bucket_names(): return ["my-test-bucket", "my-test-bucket-2"] @pytest.fixture(scope="module", autouse=True) def s3(): with mock_s3(): conn = Session( aws_access_key_id="test", aws_secret_access_key="test", region_name="us-east-1", ) yield conn @pytest.fixture(scope="module", autouse=True) def s3_resource(s3): with mock_s3(): conn = s3.resource("s3") yield conn @pytest.fixture(scope="module", autouse=True) def s3_client(s3): with mock_s3(): conn = s3.client("s3") yield conn @pytest.fixture(scope="module", autouse=True) def s3_populate(pytestconfig, s3_resource, s3_client, bucket_names): for bucket_name in bucket_names: logging.info(f"Populating s3 bucket: {bucket_name}") s3_resource.create_bucket(Bucket=bucket_name) bkt = s3_resource.Bucket(bucket_name) bkt.Tagging().put(Tagging={"TagSet": [{"Key": "foo", "Value": "bar"}]}) test_resources_dir = ( pytestconfig.rootpath / "tests/integration/s3/test_data/local_system/" ) for root, _dirs, files in os.walk(test_resources_dir): for file in files: full_path = os.path.join(root, file) rel_path = os.path.relpath(full_path, test_resources_dir) bkt.upload_file(full_path, rel_path) s3_client.put_object_tagging( Bucket=bucket_name, Key=rel_path, Tagging={"TagSet": [{"Key": "baz", "Value": "bob"}]}, ) yield SOURCE_FILES_PATH = "./tests/integration/s3/sources/s3" source_files = os.listdir(SOURCE_FILES_PATH) @pytest.mark.integration @pytest.mark.parametrize("source_file", source_files) def test_data_lake_s3_ingest( pytestconfig, s3_populate, source_file, tmp_path, mock_time ): test_resources_dir = pytestconfig.rootpath / "tests/integration/s3/" f = open(os.path.join(SOURCE_FILES_PATH, source_file)) source = json.load(f) config_dict = {} config_dict["source"] = source config_dict["sink"] = { "type": "file", "config": { "filename": f"{tmp_path}/{source_file}", }, } config_dict["run_id"] = source_file pipeline = Pipeline.create(config_dict) pipeline.run() pipeline.raise_from_status() # Verify the output. mce_helpers.check_golden_file( pytestconfig, output_path=f"{tmp_path}/{source_file}", golden_path=f"{test_resources_dir}/golden-files/s3/golden_mces_{source_file}", ) @pytest.mark.integration @pytest.mark.parametrize("source_file", source_files) def test_data_lake_local_ingest(pytestconfig, source_file, tmp_path, mock_time): test_resources_dir = pytestconfig.rootpath / "tests/integration/s3/" f = open(os.path.join(SOURCE_FILES_PATH, source_file)) source = json.load(f) config_dict = {} for path_spec in source["config"]["path_specs"]: path_spec["include"] = ( path_spec["include"] .replace( "s3://my-test-bucket/", "tests/integration/s3/test_data/local_system/" ) .replace( "s3://my-test-bucket-2/", "tests/integration/s3/test_data/local_system/" ) ) source["config"]["profiling"]["enabled"] = True source["config"].pop("aws_config") source["config"].pop("use_s3_bucket_tags", None) source["config"].pop("use_s3_object_tags", None) config_dict["source"] = source config_dict["sink"] = { "type": "file", "config": { "filename": f"{tmp_path}/{source_file}", }, } config_dict["run_id"] = source_file pipeline = Pipeline.create(config_dict) pipeline.run() pipeline.raise_from_status() # Verify the output. mce_helpers.check_golden_file( pytestconfig, output_path=f"{tmp_path}/{source_file}", golden_path=f"{test_resources_dir}/golden-files/local/golden_mces_{source_file}", ignore_paths=[ r"root\[\d+\]\['proposedSnapshot'\].+\['aspects'\].+\['created'\]\['time'\]", # root[41]['aspect']['json']['fieldProfiles'][0]['sampleValues'][0] r"root\[\d+\]\['aspect'\]\['json'\]\['fieldProfiles'\]\[\d+\]\['sampleValues'\]", # "root[0]['proposedSnapshot']['com.linkedin.pegasus2avro.metadata.snapshot.DatasetSnapshot']['aspects'][2]['com.linkedin.pegasus2avro.schema.SchemaMetadata']['fields'][4]" r"root\[\d+\]\['proposedSnapshot'\]\['com.linkedin.pegasus2avro.metadata.snapshot.DatasetSnapshot'\]\['aspects'\]\[\d+\]\['com.linkedin.pegasus2avro.schema.SchemaMetadata'\]\['fields'\]", # "root[0]['proposedSnapshot']['com.linkedin.pegasus2avro.metadata.snapshot.DatasetSnapshot']['aspects'][1]['com.linkedin.pegasus2avro.dataset.DatasetProperties']['customProperties']['size_in_bytes']" r"root\[\d+\]\['proposedSnapshot'\]\['com.linkedin.pegasus2avro.metadata.snapshot.DatasetSnapshot'\]\['aspects'\]\[\d+\]\['com.linkedin.pegasus2avro.dataset.DatasetProperties'\]\['customProperties'\]\['size_in_bytes'\]", ], ) def test_data_lake_incorrect_config_raises_error(tmp_path, mock_time): ctx = PipelineContext(run_id="test-s3") # Baseline: valid config source: dict = { "path_spec": {"include": "a/b/c/d/{table}.*", "table_name": "{table}"} } s3 = S3Source.create(source, ctx) assert s3.source_config.platform == "file" # Case 1 : named variable in table name is not present in include source = {"path_spec": {"include": "a/b/c/d/{table}.*", "table_name": "{table1}"}} with pytest.raises(ValidationError, match="table_name"): S3Source.create(source, ctx) # Case 2 : named variable in exclude is not allowed source = { "path_spec": { "include": "a/b/c/d/{table}/*.*", "exclude": ["a/b/c/d/a-{exclude}/**"], }, } with pytest.raises(ValidationError, match=r"exclude.*named variable"): S3Source.create(source, ctx) # Case 3 : unsupported file type not allowed source = { "path_spec": { "include": "a/b/c/d/{table}/*.hd5", } } with pytest.raises(ValidationError, match="file type"): S3Source.create(source, ctx) # Case 4 : ** in include not allowed source = { "path_spec": { "include": "a/b/c/d/**/*.*", }, } with pytest.raises(ValidationError, match=r"\*\*"): S3Source.create(source, ctx)