Nate Bryant 7618af549c
fix(logging): fixes slow query logging formatting and adds parsing fo… (#12955)
Co-authored-by: RyanHolstien <RyanHolstien@users.noreply.github.com>
2025-04-02 15:10:46 -05:00

423 lines
17 KiB
Java

package controllers;
import static auth.AuthUtils.ACTOR;
import static auth.AuthUtils.SESSION_COOKIE_GMS_TOKEN_NAME;
import akka.actor.ActorSystem;
import akka.stream.ActorMaterializer;
import akka.stream.Materializer;
import akka.util.ByteString;
import auth.Authenticator;
import com.datahub.authentication.AuthenticationConstants;
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.node.ObjectNode;
import com.linkedin.util.Pair;
import com.typesafe.config.Config;
import java.io.InputStream;
import java.net.URI;
import java.time.Duration;
import java.time.Instant;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutionException;
import java.util.stream.Collectors;
import javax.annotation.Nonnull;
import javax.annotation.Nullable;
import javax.inject.Inject;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import play.Environment;
import play.http.HttpEntity;
import play.libs.Json;
import play.libs.ws.InMemoryBodyWritable;
import play.libs.ws.StandaloneWSClient;
import play.libs.ws.ahc.StandaloneAhcWSClient;
import play.mvc.Controller;
import play.mvc.Http;
import play.mvc.Http.Cookie;
import play.mvc.ResponseHeader;
import play.mvc.Result;
import play.mvc.Security;
import play.shaded.ahc.org.asynchttpclient.AsyncHttpClient;
import play.shaded.ahc.org.asynchttpclient.AsyncHttpClientConfig;
import play.shaded.ahc.org.asynchttpclient.DefaultAsyncHttpClient;
import play.shaded.ahc.org.asynchttpclient.DefaultAsyncHttpClientConfig;
import utils.ConfigUtil;
public class Application extends Controller {
private static final Logger logger = LoggerFactory.getLogger(Application.class.getName());
private final Config config;
private final StandaloneWSClient ws;
private final Environment environment;
@Inject
public Application(Environment environment, @Nonnull Config config) {
this.config = config;
ws = createWsClient();
this.environment = environment;
}
/**
* Serves the build output index.html for any given path
*
* @param path takes a path string, which essentially is ignored routing is managed client side
* @return {Result} build output index.html resource
*/
@Nonnull
private Result serveAsset(@Nullable String path) {
try {
InputStream indexHtml = environment.resourceAsStream("public/index.html");
return ok(indexHtml).withHeader("Cache-Control", "no-cache").as("text/html");
} catch (Exception e) {
logger.warn("Cannot load public/index.html resource. Static assets or assets jar missing?");
return notFound().withHeader("Cache-Control", "no-cache").as("text/html");
}
}
@Nonnull
public Result healthcheck() {
return ok("GOOD");
}
/**
* index Action proxies to serveAsset
*
* @param path takes a path string which is either index.html or the path segment after /
* @return {Result} response from serveAsset method
*/
@Nonnull
public Result index(@Nullable String path) {
return serveAsset("");
}
/**
* Proxies requests to the Metadata Service
*
* <p>TODO: Investigate using mutual SSL authentication to call Metadata Service.
*/
@Security.Authenticated(Authenticator.class)
public CompletableFuture<Result> proxy(String path, Http.Request request)
throws ExecutionException, InterruptedException {
final String authorizationHeaderValue = getAuthorizationHeaderValueToProxy(request);
final String resolvedUri = mapPath(request.uri());
final String metadataServiceHost =
ConfigUtil.getString(
config,
ConfigUtil.METADATA_SERVICE_HOST_CONFIG_PATH,
ConfigUtil.DEFAULT_METADATA_SERVICE_HOST);
final int metadataServicePort =
ConfigUtil.getInt(
config,
ConfigUtil.METADATA_SERVICE_PORT_CONFIG_PATH,
ConfigUtil.DEFAULT_METADATA_SERVICE_PORT);
final boolean metadataServiceUseSsl =
ConfigUtil.getBoolean(
config,
ConfigUtil.METADATA_SERVICE_USE_SSL_CONFIG_PATH,
ConfigUtil.DEFAULT_METADATA_SERVICE_USE_SSL);
// TODO: Fully support custom internal SSL.
final String protocol = metadataServiceUseSsl ? "https" : "http";
final Map<String, List<String>> headers = request.getHeaders().toMap();
if (headers.containsKey(Http.HeaderNames.HOST)
&& !headers.containsKey(Http.HeaderNames.X_FORWARDED_HOST)) {
headers.put(Http.HeaderNames.X_FORWARDED_HOST, headers.get(Http.HeaderNames.HOST));
}
if (!headers.containsKey(Http.HeaderNames.X_FORWARDED_PROTO)) {
final String schema =
Optional.ofNullable(URI.create(request.uri()).getScheme()).orElse("http");
headers.put(Http.HeaderNames.X_FORWARDED_PROTO, List.of(schema));
}
// Get the current time to measure the duration of the request
Instant start = Instant.now();
return ws.url(
String.format(
"%s://%s:%s%s", protocol, metadataServiceHost, metadataServicePort, resolvedUri))
.setMethod(request.method())
.setHeaders(
headers.entrySet().stream()
// Remove X-DataHub-Actor to prevent malicious delegation.
.filter(
entry ->
!AuthenticationConstants.LEGACY_X_DATAHUB_ACTOR_HEADER.equalsIgnoreCase(
entry.getKey()))
.filter(entry -> !Http.HeaderNames.CONTENT_LENGTH.equalsIgnoreCase(entry.getKey()))
.filter(entry -> !Http.HeaderNames.CONTENT_TYPE.equalsIgnoreCase(entry.getKey()))
.filter(entry -> !Http.HeaderNames.AUTHORIZATION.equalsIgnoreCase(entry.getKey()))
// Remove Host s.th. service meshes do not route to wrong host
.filter(entry -> !Http.HeaderNames.HOST.equalsIgnoreCase(entry.getKey()))
.collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue)))
.addHeader(Http.HeaderNames.AUTHORIZATION, authorizationHeaderValue)
.addHeader(
AuthenticationConstants.LEGACY_X_DATAHUB_ACTOR_HEADER, getDataHubActorHeader(request))
.setBody(
new InMemoryBodyWritable(
ByteString.fromByteBuffer(request.body().asBytes().asByteBuffer()),
request.contentType().orElse("application/json")))
.setRequestTimeout(Duration.ofSeconds(120))
.execute()
.thenApply(
apiResponse -> {
// Log the query if it takes longer than the configured threshold and verbose logging
// is enabled
boolean verboseGraphQLLogging = config.getBoolean("graphql.verbose.logging");
int verboseGraphQLLongQueryMillis = config.getInt("graphql.verbose.slowQueryMillis");
Instant finish = Instant.now();
long timeElapsed = Duration.between(start, finish).toMillis();
if (verboseGraphQLLogging && timeElapsed >= verboseGraphQLLongQueryMillis) {
logSlowQuery(request, resolvedUri, timeElapsed);
}
final ResponseHeader header =
new ResponseHeader(
apiResponse.getStatus(),
apiResponse.getHeaders().entrySet().stream()
.filter(
entry ->
!Http.HeaderNames.CONTENT_LENGTH.equalsIgnoreCase(entry.getKey()))
.filter(
entry ->
!Http.HeaderNames.CONTENT_TYPE.equalsIgnoreCase(entry.getKey()))
.map(entry -> Pair.of(entry.getKey(), String.join(";", entry.getValue())))
.collect(Collectors.toMap(Pair::getFirst, Pair::getSecond)));
final HttpEntity body =
new HttpEntity.Strict(
apiResponse.getBodyAsBytes(),
Optional.ofNullable(apiResponse.getContentType()));
return new Result(header, body);
})
.toCompletableFuture();
}
/**
* Creates a wrapping ObjectNode containing config information
*
* @return Http Result instance with app configuration attributes
*/
@Nonnull
public Result appConfig() {
final ObjectNode config = Json.newObject();
config.put("application", "datahub-frontend");
config.put("appVersion", this.config.getString("app.version"));
config.put("isInternal", this.config.getBoolean("linkedin.internal"));
config.put("shouldShowDatasetLineage", this.config.getBoolean("linkedin.show.dataset.lineage"));
config.put(
"suggestionConfidenceThreshold",
Integer.valueOf(this.config.getString("linkedin.suggestion.confidence.threshold")));
config.set("wikiLinks", wikiLinks());
config.set("tracking", trackingInfo());
// In a staging environment, we can trigger this flag to be true so that the UI can handle based
// on
// such config and alert users that their changes will not affect production data
config.put("isStagingBanner", this.config.getBoolean("ui.show.staging.banner"));
config.put("isLiveDataWarning", this.config.getBoolean("ui.show.live.data.banner"));
config.put("showChangeManagement", this.config.getBoolean("ui.show.CM.banner"));
// Flag to enable people entity elements
config.put("showPeople", this.config.getBoolean("ui.show.people"));
config.put("changeManagementLink", this.config.getString("ui.show.CM.link"));
// Flag set in order to warn users that search is experiencing issues
config.put("isStaleSearch", this.config.getBoolean("ui.show.stale.search"));
config.put("showAdvancedSearch", this.config.getBoolean("ui.show.advanced.search"));
// Flag to use the new api for browsing datasets
config.put("useNewBrowseDataset", this.config.getBoolean("ui.new.browse.dataset"));
// show lineage graph in relationships tabs
config.put("showLineageGraph", this.config.getBoolean("ui.show.lineage.graph"));
// show institutional memory for available entities
config.put("showInstitutionalMemory", this.config.getBoolean("ui.show.institutional.memory"));
// Insert properties for user profile operations
config.set("userEntityProps", userEntityProps());
final ObjectNode response = Json.newObject();
response.put("status", "ok");
response.set("config", config);
return ok(response);
}
/**
* Creates a JSON object of profile / avatar properties
*
* @return Json avatar / profile image properties
*/
@Nonnull
private ObjectNode userEntityProps() {
final ObjectNode props = Json.newObject();
props.put("aviUrlPrimary", config.getString("linkedin.links.avi.urlPrimary"));
props.put("aviUrlFallback", config.getString("linkedin.links.avi.urlFallback"));
return props;
}
/**
* @return Json object with internal wiki links
*/
@Nonnull
private ObjectNode wikiLinks() {
final ObjectNode wikiLinks = Json.newObject();
wikiLinks.put("appHelp", config.getString("links.wiki.appHelp"));
wikiLinks.put("gdprPii", config.getString("links.wiki.gdprPii"));
wikiLinks.put("tmsSchema", config.getString("links.wiki.tmsSchema"));
wikiLinks.put("gdprTaxonomy", config.getString("links.wiki.gdprTaxonomy"));
wikiLinks.put("staleSearchIndex", config.getString("links.wiki.staleSearchIndex"));
wikiLinks.put("dht", config.getString("links.wiki.dht"));
wikiLinks.put("purgePolicies", config.getString("links.wiki.purgePolicies"));
wikiLinks.put("jitAcl", config.getString("links.wiki.jitAcl"));
wikiLinks.put("metadataCustomRegex", config.getString("links.wiki.metadataCustomRegex"));
wikiLinks.put("exportPolicy", config.getString("links.wiki.exportPolicy"));
wikiLinks.put("metadataHealth", config.getString("links.wiki.metadataHealth"));
wikiLinks.put("purgeKey", config.getString("links.wiki.purgeKey"));
wikiLinks.put("datasetDecommission", config.getString("links.wiki.datasetDecommission"));
return wikiLinks;
}
/**
* @return Json object containing the tracking configuration details
*/
@Nonnull
private ObjectNode trackingInfo() {
final ObjectNode piwik = Json.newObject();
piwik.put("piwikSiteId", Integer.valueOf(config.getString("tracking.piwik.siteid")));
piwik.put("piwikUrl", config.getString("tracking.piwik.url"));
final ObjectNode trackers = Json.newObject();
trackers.set("piwik", piwik);
final ObjectNode trackingConfig = Json.newObject();
trackingConfig.set("trackers", trackers);
trackingConfig.put("isEnabled", true);
return trackingConfig;
}
private StandaloneWSClient createWsClient() {
final String name = "proxyClient";
ActorSystem system = ActorSystem.create(name);
system.registerOnTermination(() -> System.exit(0));
Materializer materializer = ActorMaterializer.create(system);
AsyncHttpClientConfig asyncHttpClientConfig =
new DefaultAsyncHttpClientConfig.Builder()
.setDisableUrlEncodingForBoundRequests(true)
.setMaxRequestRetry(0)
.setShutdownQuietPeriod(0)
.setShutdownTimeout(0)
.build();
AsyncHttpClient asyncHttpClient = new DefaultAsyncHttpClient(asyncHttpClientConfig);
return new StandaloneAhcWSClient(asyncHttpClient, materializer);
}
/**
* Returns the value of the Authorization Header to be provided when proxying requests to the
* downstream Metadata Service.
*
* <p>Currently, the Authorization header value may be derived from
*
* <p>a) The value of the "token" attribute of the Session Cookie provided by the client. This
* value is set when creating the session token initially from a token granted by the Metadata
* Service.
*
* <p>Or if the "token" attribute cannot be found in a session cookie, then we fallback to
*
* <p>b) The value of the Authorization header provided in the original request. This will be used
* in cases where clients are making programmatic requests to Metadata Service APIs directly,
* without providing a session cookie (ui only).
*
* <p>If neither are found, an empty string is returned.
*/
private String getAuthorizationHeaderValueToProxy(Http.Request request) {
// If the session cookie has an authorization token, use that. If there's an authorization
// header provided, simply
// use that.
String value = "";
if (request.session().data().containsKey(SESSION_COOKIE_GMS_TOKEN_NAME)) {
value = "Bearer " + request.session().data().get(SESSION_COOKIE_GMS_TOKEN_NAME);
} else if (request.getHeaders().contains(Http.HeaderNames.AUTHORIZATION)) {
value = request.getHeaders().get(Http.HeaderNames.AUTHORIZATION).get();
}
return value;
}
/**
* Returns the value of the legacy X-DataHub-Actor header to forward to the Metadata Service. This
* is sent along with any requests that have a valid frontend session cookie to identify the
* calling actor, for backwards compatibility.
*
* <p>If Metadata Service authentication is enabled, this value is not required because Actor
* context will most often come from the authentication credentials provided in the Authorization
* header.
*/
private String getDataHubActorHeader(Http.Request request) {
String actor = request.session().data().get(ACTOR);
return actor == null ? "" : actor;
}
private String mapPath(@Nonnull final String path) {
// Case 1: Map legacy GraphQL path to GMS GraphQL API (for compatibility)
if (path.equals("/api/v2/graphql")) {
return "/api/graphql";
}
// Case 2: Map requests to /gms to / (Rest.li API)
final String gmsApiPath = "/api/gms";
if (path.startsWith(gmsApiPath)) {
String newPath = path.substring(gmsApiPath.length());
if (!newPath.startsWith("/")) {
newPath = "/" + newPath;
}
return newPath;
}
// Otherwise, return original path
return path;
}
/**
* Called if verbose logging is enabled and request takes longer that the slow query milliseconds
* defined in the config
*
* @param request GraphQL request that was made
* @param resolvedUri URI that was requested
* @param duration How long the query took to complete
*/
private void logSlowQuery(Http.Request request, String resolvedUri, float duration) {
StringBuilder jsonBody = new StringBuilder();
Optional<Cookie> actorCookie = request.getCookie("actor");
String actorValue = actorCookie.isPresent() ? actorCookie.get().value() : "N/A";
// Get the JSON body
try {
ObjectMapper mapper = new ObjectMapper();
JsonNode jsonNode = request.body().asJson();
((ObjectNode) jsonNode).remove("query");
jsonBody.append(mapper.writeValueAsString(jsonNode));
} catch (Exception e) {
logger.info("GraphQL Request Received: {}, Unable to parse JSON body", resolvedUri);
}
String jsonBodyStr = jsonBody.toString();
// Get the query string
StringBuilder query = new StringBuilder();
try {
ObjectMapper mapper = new ObjectMapper();
query.append(mapper.writeValueAsString(request.queryString()));
} catch (Exception e) {
logger.info("GraphQL Request Received: {}, Unable to parse query string", resolvedUri);
}
String queryString = query.toString();
logger.info(
"Slow GraphQL Request Received: {}, Request query string: {}, Request actor: {}, Request JSON: {}, Request completed in {} ms",
resolvedUri,
queryString,
actorValue,
jsonBodyStr,
duration);
}
}