mohdsiddique 9daa8ed56f
feat(ingestion): Business Glossary# Add domain support in GlossaryTerm ingestion (#6829)
* lint fix

* domain in term

* domain in term

* review comments

* add todo

Co-authored-by: MohdSiddique Bagwan <mohdsiddique.bagwan@gslab.com>
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
2022-12-22 17:47:57 -05:00

74 lines
2.4 KiB
Python

from typing import Any, Dict, List
import pytest
from freezegun import freeze_time
from datahub.ingestion.graph.client import DatahubClientConfig
from datahub.ingestion.run.pipeline import Pipeline
from datahub.ingestion.source.metadata import business_glossary
from tests.test_helpers import mce_helpers
FROZEN_TIME = "2020-04-14 07:00:00"
def get_default_recipe(
glossary_yml_file_path: str, event_output_file_path: str
) -> Dict[str, Any]:
return {
"source": {
"type": "datahub-business-glossary",
"config": {"file": glossary_yml_file_path},
},
"sink": {
"type": "file",
"config": {
"filename": event_output_file_path,
},
},
}
@freeze_time(FROZEN_TIME)
@pytest.mark.integration
def test_glossary_ingest(
mock_datahub_graph, docker_compose_runner, pytestconfig, tmp_path, mock_time
):
test_resources_dir = pytestconfig.rootpath / "tests/integration/business-glossary"
# These paths change from one instance run of the clickhouse docker to the other,
# and the FROZEN_TIME does not apply to these.
ignore_paths: List[str] = [
r"root\[\d+\]\['proposedSnapshot'\].+\['aspects'\].+\['customProperties'\]\['metadata_modification_time'\]",
r"root\[\d+\]\['proposedSnapshot'\].+\['aspects'\].+\['customProperties'\]\['data_paths'\]",
r"root\[\d+\]\['proposedSnapshot'\].+\['aspects'\].+\['customProperties'\]\['metadata_path'\]",
]
output_mces_path: str = f"{tmp_path}/glossary_events.json"
golden_mces_path: str = f"{test_resources_dir}/glossary_events_golden.json"
pipeline = Pipeline.create(
get_default_recipe(
glossary_yml_file_path=f"{test_resources_dir}/business_glossary.yml",
event_output_file_path=output_mces_path,
)
)
pipeline.ctx.graph = mock_datahub_graph(
DatahubClientConfig()
) # Mock to resolve domain
pipeline.run()
pipeline.raise_from_status()
# Verify the output.
mce_helpers.check_golden_file(
pytestconfig,
ignore_paths=ignore_paths,
output_path=output_mces_path,
golden_path=golden_mces_path,
)
@freeze_time(FROZEN_TIME)
def test_auto_id_creation_on_reserved_char():
id_: str = business_glossary.create_id(["pii", "secure % password"], None, False)
assert id_ == "24baf9389cc05c162c7148c96314d733"