yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-10-31 10:49:00 +00:00
Code Issues Packages Projects Releases Wiki Activity
datahub/datahub-web/@datahub/eslint-plugin/docs/rules/no-addon-import.md
Charlie Tran 843a6c5bbb
feat(frontend): update datahub-web client UI code (#1806) 
* Releases updated version of datahub-web client UI code

* Fix typo in yarn lock

* Change yarn lock to match yarn registry directories

* Previous commit missed some paths

* Even more changes to yarnlock missing in previous commit

* Include codegen file for typings

* Add files to get parity for datahub-web and current OS datahub-midtier

* Add in typo fix from previous commit - change to proper license

* Implement proper OS fix for person entity picture url

* Workarounds for open source DH issues

* Fixes institutional memory api and removes unopensourced tabs for datasets

* Fixes search dataset deprecation and user search issue as a result of changes

* Remove internal only options in the avatar menu
2020-08-26 15:44:50 -07:00

742 B
Raw Blame History

Imports should not containt /addon/ (no-addon-import)

VScode usually autocompletes the import with /addon/ which is invalid in ember and will yield some errors. There are some cases where the import only affect TS (types) and then it will compile fine, but we want to mantain consistency across code, therefore, having /addon/ importing ember addons should not be allowed.

Rule Details

Examples of incorrect code for this rule:

import something from 'someemberaddon/addon/component/something';

Examples of correct code for this rule:

import something from 'someemberaddon/component/something';

When Not To Use It

If you are having conflics with naming and you really want to import /addon/