mirror of
https://github.com/datahub-project/datahub.git
synced 2025-08-13 19:57:12 +00:00
843a6c5bbb
* Releases updated version of datahub-web client UI code * Fix typo in yarn lock * Change yarn lock to match yarn registry directories * Previous commit missed some paths * Even more changes to yarnlock missing in previous commit * Include codegen file for typings * Add files to get parity for datahub-web and current OS datahub-midtier * Add in typo fix from previous commit - change to proper license * Implement proper OS fix for person entity picture url * Workarounds for open source DH issues * Fixes institutional memory api and removes unopensourced tabs for datasets * Fixes search dataset deprecation and user search issue as a result of changes * Remove internal only options in the avatar menu
27 lines
742 B
Markdown
27 lines
742 B
Markdown
# Imports should not containt /addon/ (no-addon-import)
|
|
|
|
VScode usually autocompletes the import with `/addon/` which is invalid in ember
|
|
and will yield some errors. There are some cases where the import only affect TS (types)
|
|
and then it will compile fine, but we want to mantain consistency across code, therefore,
|
|
having `/addon/` importing ember addons should not be allowed.
|
|
|
|
## Rule Details
|
|
|
|
Examples of **incorrect** code for this rule:
|
|
|
|
```js
|
|
import something from 'someemberaddon/addon/component/something';
|
|
|
|
```
|
|
|
|
Examples of **correct** code for this rule:
|
|
|
|
```js
|
|
import something from 'someemberaddon/component/something';
|
|
|
|
```
|
|
|
|
## When Not To Use It
|
|
|
|
If you are having conflics with naming and you really want to import `/addon/`
|