yujunjun/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2025-08-18 22:28:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

bug: fix sequence number may be duplicated when multi-threads running the same workflow #21047 (#21153)

Browse Source
This commit is contained in:
NeatGuyCoding 2025-06-18 16:10:11 +08:00 committed by GitHub
parent 99acdcdef7
commit 918bb9a2f7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
api/core/repositories/sqlalchemy_workflow_execution_repository.py
View File

@ -151,12 +151,17 @@ class SQLAlchemyWorkflowExecutionRepository(WorkflowExecutionRepository):
existing = session.scalar(select(WorkflowRun).where(WorkflowRun.id == domain_model.id_)) existing = session.scalar(select(WorkflowRun).where(WorkflowRun.id == domain_model.id_))
if not existing: if not existing:
# For new records, get the next sequence number # For new records, get the next sequence number
stmt = select(func.max(WorkflowRun.sequence_number)).where( # in case multiple executions are created concurrently, use for update
stmt = (
select(func.coalesce(func.max(WorkflowRun.sequence_number), 0) + 1)
.where(
WorkflowRun.app_id == self._app_id, WorkflowRun.app_id == self._app_id,
WorkflowRun.tenant_id == self._tenant_id, WorkflowRun.tenant_id == self._tenant_id,
) )
max_sequence = session.scalar(stmt) .with_for_update()
db_model.sequence_number = (max_sequence or 0) + 1 )
next_seq = session.scalar(stmt)
db_model.sequence_number = int(next_seq) if next_seq is not None else 1
else: else:
# For updates, keep the existing sequence number # For updates, keep the existing sequence number
db_model.sequence_number = existing.sequence_number db_model.sequence_number = existing.sequence_number