2023-07-17 15:06:19 +02:00
|
|
|
from typing import Dict, Any, List, Optional
|
2023-06-27 17:42:23 +02:00
|
|
|
|
|
|
|
import pytest
|
|
|
|
|
|
|
|
from haystack.preview import Pipeline
|
|
|
|
from haystack.preview.components.retrievers.memory import MemoryRetriever
|
|
|
|
from haystack.preview.dataclasses import Document
|
2023-07-17 15:06:19 +02:00
|
|
|
from haystack.preview.document_stores import Store, MemoryDocumentStore
|
2023-06-27 17:42:23 +02:00
|
|
|
|
|
|
|
from test.preview.components.base import BaseTestComponent
|
|
|
|
|
2023-07-17 15:06:19 +02:00
|
|
|
from haystack.preview.document_stores.protocols import DuplicatePolicy
|
|
|
|
|
2023-06-27 17:42:23 +02:00
|
|
|
|
|
|
|
@pytest.fixture()
|
|
|
|
def mock_docs():
|
|
|
|
return [
|
|
|
|
Document.from_dict({"content": "Javascript is a popular programming language"}),
|
|
|
|
Document.from_dict({"content": "Java is a popular programming language"}),
|
|
|
|
Document.from_dict({"content": "Python is a popular programming language"}),
|
|
|
|
Document.from_dict({"content": "Ruby is a popular programming language"}),
|
|
|
|
Document.from_dict({"content": "PHP is a popular programming language"}),
|
|
|
|
]
|
|
|
|
|
|
|
|
|
2023-07-17 15:06:19 +02:00
|
|
|
class TestMemoryRetriever(BaseTestComponent):
|
2023-06-27 17:42:23 +02:00
|
|
|
@pytest.mark.unit
|
|
|
|
def test_save_load(self, tmp_path):
|
2023-07-17 15:06:19 +02:00
|
|
|
self.assert_can_be_saved_and_loaded_in_pipeline(MemoryRetriever(), tmp_path)
|
2023-06-27 17:42:23 +02:00
|
|
|
|
|
|
|
@pytest.mark.unit
|
|
|
|
def test_save_load_with_parameters(self, tmp_path):
|
2023-07-17 15:06:19 +02:00
|
|
|
self.assert_can_be_saved_and_loaded_in_pipeline(MemoryRetriever(top_k=5, scale_score=False), tmp_path)
|
2023-06-27 17:42:23 +02:00
|
|
|
|
|
|
|
@pytest.mark.unit
|
|
|
|
def test_init_default(self):
|
2023-07-17 15:06:19 +02:00
|
|
|
retriever = MemoryRetriever()
|
2023-06-27 17:42:23 +02:00
|
|
|
assert retriever.defaults == {"filters": {}, "top_k": 10, "scale_score": True}
|
|
|
|
|
|
|
|
@pytest.mark.unit
|
|
|
|
def test_init_with_parameters(self):
|
2023-07-17 15:06:19 +02:00
|
|
|
retriever = MemoryRetriever(top_k=5, scale_score=False)
|
2023-06-27 17:42:23 +02:00
|
|
|
assert retriever.defaults == {"filters": {}, "top_k": 5, "scale_score": False}
|
|
|
|
|
|
|
|
@pytest.mark.unit
|
|
|
|
def test_init_with_invalid_top_k_parameter(self):
|
|
|
|
with pytest.raises(ValueError, match="top_k must be > 0, but got -2"):
|
2023-07-17 15:06:19 +02:00
|
|
|
MemoryRetriever(top_k=-2, scale_score=False)
|
2023-06-27 17:42:23 +02:00
|
|
|
|
|
|
|
@pytest.mark.unit
|
|
|
|
def test_valid_run(self, mock_docs):
|
|
|
|
top_k = 5
|
|
|
|
ds = MemoryDocumentStore()
|
|
|
|
ds.write_documents(mock_docs)
|
2023-07-17 15:06:19 +02:00
|
|
|
|
|
|
|
retriever = MemoryRetriever(top_k=top_k)
|
|
|
|
retriever.store = ds
|
|
|
|
result = retriever.run(data=retriever.input(queries=["PHP", "Java"]))
|
2023-06-27 17:42:23 +02:00
|
|
|
|
|
|
|
assert getattr(result, "documents")
|
2023-07-07 12:10:35 +02:00
|
|
|
assert len(result.documents) == 2
|
|
|
|
assert len(result.documents[0]) == top_k
|
|
|
|
assert len(result.documents[1]) == top_k
|
|
|
|
assert result.documents[0][0].content == "PHP is a popular programming language"
|
|
|
|
assert result.documents[1][0].content == "Java is a popular programming language"
|
2023-06-27 17:42:23 +02:00
|
|
|
|
|
|
|
@pytest.mark.unit
|
2023-07-17 15:06:19 +02:00
|
|
|
def test_invalid_run_no_store(self):
|
|
|
|
retriever = MemoryRetriever()
|
|
|
|
with pytest.raises(
|
|
|
|
ValueError, match="MemoryRetriever needs a store to run: set the store instance to the self.store attribute"
|
|
|
|
):
|
|
|
|
retriever.run(retriever.input(queries=["test"]))
|
|
|
|
|
|
|
|
@pytest.mark.unit
|
|
|
|
def test_invalid_run_not_a_store(self):
|
|
|
|
class MockStore:
|
|
|
|
...
|
|
|
|
|
|
|
|
retriever = MemoryRetriever()
|
|
|
|
with pytest.raises(ValueError, match="does not respect the Store Protocol"):
|
|
|
|
retriever.store = MockStore()
|
2023-06-27 17:42:23 +02:00
|
|
|
|
|
|
|
@pytest.mark.unit
|
|
|
|
def test_invalid_run_wrong_store_type(self):
|
2023-07-17 15:06:19 +02:00
|
|
|
class MockStore:
|
|
|
|
def count_documents(self) -> int:
|
|
|
|
return 0
|
|
|
|
|
|
|
|
def filter_documents(self, filters: Optional[Dict[str, Any]] = None) -> List[Document]:
|
|
|
|
return []
|
|
|
|
|
|
|
|
def write_documents(
|
|
|
|
self, documents: List[Document], policy: DuplicatePolicy = DuplicatePolicy.FAIL
|
|
|
|
) -> None:
|
|
|
|
return None
|
|
|
|
|
|
|
|
def delete_documents(self, document_ids: List[str]) -> None:
|
|
|
|
return None
|
|
|
|
|
|
|
|
retriever = MemoryRetriever()
|
|
|
|
with pytest.raises(ValueError, match="is not compatible with this component"):
|
|
|
|
retriever.store = MockStore()
|
2023-06-27 17:42:23 +02:00
|
|
|
|
|
|
|
@pytest.mark.integration
|
|
|
|
@pytest.mark.parametrize(
|
|
|
|
"query, query_result",
|
|
|
|
[
|
|
|
|
("Javascript", "Javascript is a popular programming language"),
|
|
|
|
("Java", "Java is a popular programming language"),
|
|
|
|
],
|
|
|
|
)
|
|
|
|
def test_run_with_pipeline(self, mock_docs, query: str, query_result: str):
|
|
|
|
ds = MemoryDocumentStore()
|
|
|
|
ds.write_documents(mock_docs)
|
2023-07-17 15:06:19 +02:00
|
|
|
retriever = MemoryRetriever()
|
2023-06-27 17:42:23 +02:00
|
|
|
|
|
|
|
pipeline = Pipeline()
|
|
|
|
pipeline.add_store("memory", ds)
|
2023-07-17 15:06:19 +02:00
|
|
|
pipeline.add_component("retriever", retriever, store="memory")
|
|
|
|
result: Dict[str, Any] = pipeline.run(data={"retriever": retriever.input(queries=[query])})
|
2023-06-27 17:42:23 +02:00
|
|
|
|
|
|
|
assert result
|
|
|
|
assert "retriever" in result
|
|
|
|
results_docs = result["retriever"].documents
|
|
|
|
assert results_docs
|
2023-07-07 12:10:35 +02:00
|
|
|
assert results_docs[0][0].content == query_result
|
2023-06-27 17:42:23 +02:00
|
|
|
|
|
|
|
@pytest.mark.integration
|
|
|
|
@pytest.mark.parametrize(
|
|
|
|
"query, query_result, top_k",
|
|
|
|
[
|
|
|
|
("Javascript", "Javascript is a popular programming language", 1),
|
|
|
|
("Java", "Java is a popular programming language", 2),
|
|
|
|
("Ruby", "Ruby is a popular programming language", 3),
|
|
|
|
],
|
|
|
|
)
|
|
|
|
def test_run_with_pipeline_and_top_k(self, mock_docs, query: str, query_result: str, top_k: int):
|
|
|
|
ds = MemoryDocumentStore()
|
|
|
|
ds.write_documents(mock_docs)
|
2023-07-17 15:06:19 +02:00
|
|
|
retriever = MemoryRetriever()
|
2023-06-27 17:42:23 +02:00
|
|
|
|
|
|
|
pipeline = Pipeline()
|
|
|
|
pipeline.add_store("memory", ds)
|
2023-07-17 15:06:19 +02:00
|
|
|
pipeline.add_component("retriever", retriever, store="memory")
|
|
|
|
result: Dict[str, Any] = pipeline.run(data={"retriever": retriever.input(queries=[query], top_k=top_k)})
|
2023-06-27 17:42:23 +02:00
|
|
|
|
|
|
|
assert result
|
|
|
|
assert "retriever" in result
|
|
|
|
results_docs = result["retriever"].documents
|
|
|
|
assert results_docs
|
2023-07-07 12:10:35 +02:00
|
|
|
assert len(results_docs[0]) == top_k
|
|
|
|
assert results_docs[0][0].content == query_result
|